http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402012-06-28T00:59:59ZRedmineAudacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4242012-06-28T00:59:59ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>It has already been mentioned that the workaround is no longer necessary for GTK+ 3.5, and perhaps we will take it out once GTK+ 3.5 is released, but how is it "broken"?</p>
<p>(Edit: That is, when 3.5 becomes 3.6.)</p> Audacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4272012-06-28T07:35:14ZJean-Louis Dupondjean-louis@dupond.be
<ul></ul><p>Well i'm on Ubuntu Quantal which already has GTK+ 3.5.</p>
<p>Clicking on the slider doesn't do anything anymore.<br />You can only change position when dragging the slider.</p>
<p>I think the attached patch is the way to go.<br />Don't think its good to lose compatibility with GTK+ < 3.5</p> Audacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4282012-06-28T17:35:48ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>File</strong> <a href="/attachments/90/GTK35.patch">GTK35.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/90/GTK35.patch">GTK35.patch</a> added</li></ul><p>The two functions with the hack are no more needed at all.</p>
<p>In my opinion Audacious should really have these version checks too.<br />Now, not when 3.6.0 is released.<br />Generally I agree with your opinion, John. But not in this case.</p>
<p>By the way, rhythmbox got a commit today which fixes the same bug:<br /><a class="external" href="http://git.gnome.org/browse/rhythmbox/commit/?id=a16a8bb41090233a28778e45f277e94de091f773">http://git.gnome.org/browse/rhythmbox/commit/?id=a16a8bb41090233a28778e45f277e94de091f773</a></p> Audacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4292012-06-28T23:56:42ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Jean-Louis Dupond wrote:</p>
<blockquote>
<p>Clicking on the slider doesn't do anything anymore.<br />You can only change position when dragging the slider.</p>
</blockquote>
<p>Hi, thanks for FINALLY STATING WHAT THE PROBLEM IS. Useless discussions (and disagreements) can go on a long time if you leave out the critical piece of information. (Mr. Lange, I'm talking to you also.)</p> Audacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4302012-06-29T00:06:09ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>3.3</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul> Audacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4312012-06-29T00:35:48ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>Do you really want to remove compatibility with GTK <= 3.4 with Audacious 3.3?<br />What happens if "someone" files bug report <a class="issue tracker-1 status-6 priority-4 priority-default closed" title="Bug: Files with a sample rate less than 33kHz don't play (Rejected)" href="http://redmine.audacious-media-player.org/issues/139">#139</a> titled "Song slider broken on GTK <= 3.4.3"?</p>
<p>Will you reject it? Gosh...</p> Audacious - Bug #138: Song slider broken on GTK >= 3.5.0http://redmine.audacious-media-player.org/issues/138?journal_id=4322012-06-29T03:54:56ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>We haven't "removed compatibility" with GTK+ 3.4. We only reverted to the behavior GtkSlider has in other applications: you use middle-click to set the position directly (just like on a scrollbar). And yes, if "someone" has the gall to file that bug report, I will reject it.</p>