http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402013-08-28T03:25:07ZRedmineAudacious - Bug #336: [PATCH]: Fix skinned ui not being drawn properly with gtk-3 >= 3.9http://redmine.audacious-media-player.org/issues/336?journal_id=11782013-08-28T03:25:07ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>I think the more proper fix is to return FALSE from our draw functions, letting GTK+ propagate the signal. Then, we use gtk_widget_set_app_paintable() to keep GTK+ from drawing the default window background.</p>
<p><a class="external" href="https://github.com/audacious-media-player/audacious-plugins/commit/2a43c567fec21b34825869ce10d68277c4361097">https://github.com/audacious-media-player/audacious-plugins/commit/2a43c567fec21b34825869ce10d68277c4361097</a></p> Audacious - Bug #336: [PATCH]: Fix skinned ui not being drawn properly with gtk-3 >= 3.9http://redmine.audacious-media-player.org/issues/336?journal_id=11792013-08-28T03:25:40ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Target version</strong> set to <i>3.4.1</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Affects version</strong> <i>3.4</i> added</li></ul> Audacious - Bug #336: [PATCH]: Fix skinned ui not being drawn properly with gtk-3 >= 3.9http://redmine.audacious-media-player.org/issues/336?journal_id=11812013-08-28T10:17:13ZHans de Goede
<ul></ul><p>I can confirm that the committed fix also fixes the skinned ui drawing issues with gtk-master.</p>
<p>When looking at the patch I noticed that it changes the return value for all draw handlers in the skinned ui. Would it not be better to have a new DRAW_FUNC_END_FALSE macro, and use that to end window_draw, and keep the other draw function returning TRUE ?</p>
<p>Note I'm not seeing any adverse side-effects of the current solution.</p> Audacious - Bug #336: [PATCH]: Fix skinned ui not being drawn properly with gtk-3 >= 3.9http://redmine.audacious-media-player.org/issues/336?journal_id=11862013-08-29T15:52:27ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>For GtkDrawingArea, I don't think it matters whether we return TRUE or FALSE since GTK+ doesn't do any further processing. I favor FALSE if only because it's consistent with e.g. GtkWindow. Unfortunately the GTK+ docs don't provide any guidance here.</p>