http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402014-10-14T16:47:48ZRedmineAudacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17302014-10-14T16:47:48ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Target version</strong> deleted (<del><i>3.6</i></del>)</li><li><strong>Category</strong> changed from <i>libaudqt</i> to <i>plugins/qtui</i></li><li><strong>Priority</strong> changed from <i>Blocker</i> to <i>Major</i></li></ul><p>I don't think this should be a blocker for 3.6 since the Qt UI is only going to be a technical preview in that release. Some of the translations will not appear without a fair amount of work, since Qt Designer does not support our gettext-based translations.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17402014-10-17T21:44:07ZAriadne Conillariadne@dereferenced.org
<ul></ul><p>I am planning to remove the last bits of the Qt Designer stuff this weekend.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17612014-10-26T17:13:57ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>I fixed several issues in the PreferencesWidget code; all of the settings dialog should be translated now.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17632014-10-27T01:05:29ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul><p>Thanks John, good work.<br />I just fixed some remaining issues.</p>
<p>TODO:<br />- menu bar<br />- dialog buttons<br />- combobox "Preferences->Audio->Bit depth" <br />- combobox "Preferences->Playlist->Auto character encoding detector for:" <br />- tooltip "Close Tab" on tab close buttons</p>
<p>The dialog buttons and the tooltip should be translated by Qt, but apparently they are not.<br />We could either use custom QPushButtons or something like this:</p>
<pre>
m_buttonbox.setStandardButtons (QDialogButtonBox::Ok | QDialogButtonBox::Cancel);
+ m_buttonbox.button (QDialogButtonBox::Ok)->setText (translate_str ("_OK"));
+ m_buttonbox.button (QDialogButtonBox::Cancel)->setText (translate_str ("_Cancel"));
</pre> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17642014-10-29T00:40:41ZAriadne Conillariadne@dereferenced.org
<ul></ul><p>Qt designer vestiges have been nuked. The menus should now be translated.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17652014-10-29T01:37:47ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>At first it still used the English strings, but the fix was trivial.<br />Using <em>() instead of N</em>() resolved it.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17662014-10-29T01:46:02ZAriadne Conillariadne@dereferenced.org
<ul></ul><p>That fix is incorrect. Please revert.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17672014-10-29T02:00:09ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>Done, sorry for the inconvenience.<br />What is the proper fix though?</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17682014-10-29T02:02:43ZAriadne Conillariadne@dereferenced.org
<ul></ul><p>Please try latest libaudqt, it should have an appropriate fix.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17692014-10-29T02:09:01ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>It is the same as before, still not translated.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17702014-10-29T02:17:59ZAriadne Conillariadne@dereferenced.org
<ul></ul><p>Best to leave it to jlindgren then, the current approach is the same as libaudgui basically.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17752014-10-30T22:58:53ZAriadne Conillariadne@dereferenced.org
<ul></ul><p>Qt itself can be translated by installing a custom translator which is subclassed from QTranslator. I'll work on that this weekend, it might help.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17762014-10-31T23:45:32ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>William Pitcock wrote:</p>
<blockquote>
<p>Best to leave it to jlindgren then, the current approach is the same as libaudgui basically.</p>
</blockquote>
<p>One of the pitfalls of this approach is that it's easy for the gettext domain to get dropped at some point in the call tree. There were a couple of places where this was happening in libaudqt. Menu translations should be fixed now.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=17782014-11-01T15:02:31ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>John Lindgren wrote:</p>
<blockquote>
<p>Menu translations should be fixed now.</p>
</blockquote>
<p>Thanks, confirming it works.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=18312014-12-06T01:09:50ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>Another issue remains in the file dialog (libaudqt/fileopener.cc#46).</p>
<p>If we translate the button label with "translate_str (N_("_Add"))", the accelerator<br />is converted to the Qt one (&). But Qt itself uses on GTK systems a native GTK dialog<br />and in this case the string is shown literally as "&Add".<br />If we just use _("_Add"), the accelerator is wrong on Qt systems.</p>
<p>Additionally it would be nice to show an icon on this button.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=19212015-02-12T19:09:05ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>File</strong> <a href="/attachments/447/translate_qt_buttons.patch">translate_qt_buttons.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/447/translate_qt_buttons.patch">translate_qt_buttons.patch</a> added</li></ul><p>With the attached patch all dialog buttons are translatable.<br />The strings are already used in the GTK interface so no further translation work is needed.</p>
<p>My suggestion is to use this solution until William implements a custom QTranslator.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=19222015-02-13T00:41:41ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Looks fine to me.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=20912015-06-20T00:40:54ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>Affects version</strong> deleted (<del><i>3.6</i></del>)</li></ul><p>Update for 3.7-devel:</p>
<p>PreferencesWidgets in <em>"/skins-qt/skins_cfg.cc"</em> are not shown translated currently.</p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=20952015-06-20T04:34:19ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p><a class="external" href="https://github.com/audacious-media-player/audacious/commit/d2e2e7bc52c694871e34585e91e641ee4c27bd52">https://github.com/audacious-media-player/audacious/commit/d2e2e7bc52c694871e34585e91e641ee4c27bd52</a></p> Audacious - Bug #466: Qt: Translations are not appliedhttp://redmine.audacious-media-player.org/issues/466?journal_id=21312015-07-18T18:43:38ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>3.7</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Closing this since it looks like the issues have all been fixed.</p>