Bug #558

skins-qt: scrolling song title causes gfx glitches (OS X)

Added by William Pitcock almost 2 years ago. Updated 3 months ago.

Status:Rejected Start date:July 05, 2015
Priority:Minor Due date:
Assignee:- % Done:

0%

Category:plugins/skins-qt
Target version:-
Affects version:3.7-alpha1

Description

Hello,

When scrolling song title is enabled, it causes other widgets on the skin to not be rendered occasionally. I can attach a video if you need.

Associated revisions

Revision c375d1a9
Added by William Pitcock almost 2 years ago

skins-qt: Widget::draw_now(): use update() instead of repaint() as proposed by jlindgren. Closes #558

History

#1 Updated by John Lindgren almost 2 years ago

  • Category set to plugins/skins-qt
  • Affects version 3.7-alpha1 added

I've seen something like this too, but maybe it would be just as well to attach a video to make sure we're talking about the same thing.

#3 Updated by John Lindgren almost 2 years ago

Hmm, I have not seen this.

In widget.h, does it make any difference if you change

    void draw_now () { repaint (); }
to
    void draw_now () { update (); }
?

#4 Updated by William Pitcock almost 2 years ago

That fixed it, I went ahead and pushed it.

#5 Updated by William Pitcock almost 2 years ago

It still glitches when the window doesn't have focus, but I think that has to do with event dispatch perhaps.

#6 Updated by John Lindgren almost 2 years ago

William Pitcock wrote:

That fixed it, I went ahead and pushed it.

Please make the change specific to Mac; repaint() works fine on X11 and is a much less expensive operation since it draws only a single widget, whereas update() redraws the whole window.

#7 Updated by John Lindgren almost 2 years ago

  • Subject changed from skins-qt: scrolling song title causes gfx glitches to skins-qt: scrolling song title causes gfx glitches (OS X)

#8 Updated by John Lindgren 3 months ago

  • Status changed from New to Rejected

Closing OS X-specific bugs since development on that OS seems to have stalled.

Also available in: Atom PDF