Redmine: Issueshttp://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402013-04-24T10:27:53ZRedmine
Redmine Audacious - Feature #284 (Rejected): Scrobbler 2.0 doesn't scrobble all the tracks of an audio st...http://redmine.audacious-media-player.org/issues/2842013-04-24T10:27:53ZMichael Jacobsmue@muespace.net
<p>I just had a short look at the source of 3.4 beta 1 and it seemed to me that the plugin does not have a proper treatment of audio streams.</p>
<p>The problem is, that a stream is one item in the playlist. But it anyway may consist of different tracks that are provided by the stream. This can usually be noticed by the changed title information as soon as a new song starts.</p>
<p>It looks to me, that the current code scrobbles a stream exactly once. So only one of the tracks in a stream is transmitted, which is likely not, what one would like to have.</p>
<p>John Lindgren added last summer a patch that solved this issue by also taking the appropriate actions in case that a change of the meta data was detected.</p>
<p>Furthermore, this is also related to the "Listening Now" feature requested in <a class="issue tracker-2 status-5 priority-5 priority-high3 closed" title="Feature: Scrobbler 2.0 plugin doesn't scrobble "Listening now" (Closed)" href="http://redmine.audacious-media-player.org/issues/261">#261</a>. Last.fm only displays the listening now information at most as long as the title lasts according to the information transmitted to server for listening now. The problem with tracks in streams is that you do not know, how long they will still last from the moment that you started listening to them. But in order to display the track in any case as long as you listen to it, you would have to initially assume a huge length for all stream tracks, but there might always be tracks even longer. In the end, the old scrobbler plugin just assumed a short length for stream tracks initially for "Listening now" and after that period had retransmitted another "Listening now" request with an increased length for the track.</p>
<p>Those aspects were discussed in feature request <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Scrobbling support for http streams (Closed)" href="http://redmine.audacious-media-player.org/issues/109">#109</a>.</p>
<p>To sum it up, I'm quite happy that somebody provided a clean implementation of the scrobbler plugin. But anyway, I would be more happy to also find a decent treatment of audio streams in the new scrobbler plugin. Maybe we can use this as a starting point for further discussion.</p> Audacious - Feature #109 (Closed): Scrobbling support for http streamshttp://redmine.audacious-media-player.org/issues/1092012-05-08T20:25:41ZMichael Jacobsmue@muespace.net
<p>I did a small hack to also provide scrobbling for http streams. Check the log of my conversation with John Lindgren for further details.</p>
<hr />
<p>Hi John,</p>
<p>I recently started to listen to an online stream using audacious, which has been my favorite music player for years now.</p>
<p>I am not even sure, if you are the right person to ask concerning the scrobbler plugin, but I just saw on git hub, that you were the last one who worked on the corresponding files.</p>
<p>A thing that annoyed me a bit, was that none of the tracks I listened to in the stream was scrobbeled to last.fm, although all the tracks where properly tagged. After taking a look into the scroobler plugin's source, I discovered, that this is no accident and was just intended by design.</p>
<p>So my question is: Is it planned to implement scrobbling also for internet streams? Or was it lewft out because many streams do not provide meaningful tags or additionally add their own stuff to them?</p>
<p>Last weekend, I spent a few hours on the plugin and added a straight forward hack that enabled the scrobbling for streams and also detected when the tag changed for a new title. I am not the best C programmer (probably I violated many coding conventions or added some vulnerabilities) and I only tested the build and running on my machine (Arch Linux). But maybe my piece of code could be usefull to safe some work if somebody at the plugin team decides to implement scrobbling for streams one day. I would like to provide the code to the team, if it could be usefull in any way. I am happy with audacious for so many years now, maybe I can give at least a little thing back.</p>
<p>Would it be usefull to provide a git patch and if yes, who would like to receive the patch?</p>
<p>Regards<br />Michael</p>
<hr />
<p>Hi Michael,</p>
<p>The author of the scrobbler plugin hasn't been doing any work on<br />Audacious recently, so it's more or less orphaned at the moment. The<br />best way to submit a patch is to create a feature request on the bug<br />tracker and attach it there. I can't promise I will get to it<br />immediately, but I hope to have more time for such things this summer.</p>
<p>-- John</p>