Redmine: Issueshttp://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402020-12-07T04:35:38ZRedmine
Redmine Audacious - Feature #1038 (Closed): Eliminate dependence on QEventDispatcherGlibhttp://redmine.audacious-media-player.org/issues/10382020-12-07T04:35:38ZJohn Lindgrenjohn@jlindgren.net
<p>D-Bus support is not working on Windows when running in Qt mode, because Qt is not running a GLib main loop there.</p>
<p>We could try to recompile Qt on Windows with GLib support, but I'm not certain if this would work (there may be parts of Qt that depend on using QEventDispatcherWin32).</p>
<p>Probably a more portable solution would be to modify dbus-server.cc to run its own main loop in a dedicated thread for D-Bus operations.</p> Audacious - Bug #935 (Closed): "Next album" is broken when there's no next albumhttp://redmine.audacious-media-player.org/issues/9352020-01-09T03:37:49ZJohn Lindgrenjohn@jlindgren.net
<p>When used in the middle of the last album in the playlist, the new "next album" code exits early and leaves the playlist in an inconsistent state (the "play" icon doesn't match the song actually playing).</p>
<p>It needs a rewrite similar to what I just pushed for the "previous album" code.</p> Audacious - Feature #916 (Closed): Tag editor improvementshttp://redmine.audacious-media-player.org/issues/9162019-11-14T16:19:15ZJohn Lindgrenjohn@jlindgren.net
<p>The song info window of the Qt UI could be made into a much more useful tag editor with some improvements.</p>
<p>Some ideas:</p>
<ol>
<li>Make field values editable with a single click; the current behavior ("click twice slowly") is awkward</li>
<li>Allow navigating between fields with the Up and Down arrow keys while editing</li>
<li>Enable the "Save" button only when changes are made, and disable again once successfully saved</li>
<li>Add a "Revert" button to go back to on-disk values, and enable/disable with the "Save" button</li>
<li>Display unsaved changes in bold text until saved</li>
</ol>
Bonus goal -- allow displaying/editing tags of multiple files at once (by selecting multiple files before pressing Alt-I):
<ul>
<li>We could do a cool stack/overlay of multiple album art images in place of the single image display</li>
<li>The path label could just display something like "8 files selected" </li>
<li>Set the text of the "Save" button to "Save 8 files" just to be extra clear</li>
<li>Fields that were identical between all tags would be displayed and editable like normal</li>
<li>Fields that differed between tags should be display disabled text like "Various; press Delete to clear all" </li>
<li>Pressing the Delete key would clear the existing, different values and allow editing those fields</li>
</ul> Audacious - Bug #859 (New): .wsz skins cannot be used on Windowshttp://redmine.audacious-media-player.org/issues/8592019-01-10T05:13:52ZJohn Lindgrenjohn@jlindgren.net
<p>The current scheme uses the external "unzip" program which generally isn't present on Windows.</p>
<p>We could ship an "unzip.exe" along with the Windows build, but it would be better if we could read the .wsz/.zip files directly through the VFS layer, without running an external .exe and creating temporary files on the C: drive.</p> Audacious - Bug #760 (Rejected): Credits for some pre-Transifex translators are missinghttp://redmine.audacious-media-player.org/issues/7602017-12-13T14:19:02ZJohn Lindgrenjohn@jlindgren.net
<p>It was brought to my attention that the list of contributors in some of the .po files are incomplete. The problem appears to be that some copyright statements weren't parsed correctly and preserved in the first upload to Transifex.</p>
<p>As one example, uk.po is missing attribution to Dmytro Koval'ov and Mykola Lynnyk since this commit:<br /><a class="external" href="https://github.com/audacious-media-player/audacious/commit/1a013156d209b1b4434e0bfd47e904ac7b1f3e96">https://github.com/audacious-media-player/audacious/commit/1a013156d209b1b4434e0bfd47e904ac7b1f3e96</a></p>
<p>We should look at the other commits where pre-Transifex .po files were first replaced with Transifex versions, and check for other names that may have gone missing.</p> Audacious - Bug #725 (Closed): [xsf] Many warnings with GCC 7http://redmine.audacious-media-player.org/issues/7252017-06-07T02:57:13ZJohn Lindgrenjohn@jlindgren.net
<p>The xsf plugin generates many warnings with GCC 7.1.1, such as:<br /><pre>
desmume/MMU.cc: In function ‘void MMU_clearMem()’:
desmume/MMU.cc:310:43: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size]
memset(ARM9Mem.blank_memory, 0, 0x020000);
^
</pre><pre>
In file included from desmume/armcpu.h:26:0,
from desmume/cp15.h:25,
from desmume/arm_instructions.cc:25:
desmume/arm_instructions.cc: In function ‘u32 OP_SBC_S_LSL_IMM(armcpu_t*)’:
desmume/arm_instructions.cc:1333:46: warning: ‘~’ on an expression of type bool [-Wbool-operation]
cpu->CPSR.bits.V = SIGNED_UNDERFLOW(v, (!cpu->CPSR.bits.C), tmp) | SIGNED_UNDERFLOW(tmp, shift_op, cpu->R[REG_POS(i,12)]);\
desmume/bits.h:38:23: note: in definition of macro ‘BIT31’
#define BIT31(i) ((i)>>31)
^
desmume/arm_instructions.cc:1333:25: note: in expansion of macro ‘SIGNED_UNDERFLOW’
cpu->CPSR.bits.V = SIGNED_UNDERFLOW(v, (!cpu->CPSR.bits.C), tmp) | SIGNED_UNDERFLOW(tmp, shift_op, cpu->R[REG_POS(i,12)]);\
^~~~~~~~~~~~~~~~
desmume/arm_instructions.cc:1343:6: note: in expansion of macro ‘OP_SBCS’
OP_SBCS(2, 4);
^~~~~~~
desmume/arm_instructions.cc:1333:46: note: did you mean to use logical not (‘!’)?
</pre>These look like legitimate problems, and I'm not familiar enough with the code to implement a fix. We also have a very old fork of desmume while upstream has moved on (<a class="external" href="https://github.com/TASVideos/desmume">https://github.com/TASVideos/desmume</a>).</p>
<p><a class="user active" href="/users/155">Ariadne Conill</a>: Thoughts? Do you have any interest in updating this plugin or at least fixing the warnings?</p> Audacious - Bug #655 (Closed): audtool: limited operation on Win32http://redmine.audacious-media-player.org/issues/6552016-08-04T03:07:16ZJohn Lindgrenjohn@jlindgren.net
<p>audtool currently has some major limitations on Win32:</p>
<p>1. Console output is not visible unless redirected to a file.<br />2. All commands go to the primary instance of Audacious.</p>
<p>#1 is probably due to compiler flags and should be a simple fix. <a class="issue tracker-1 status-5 priority-5 priority-high3 closed" title="Bug: [pulse] Volume changes made when not playing have no effect (Closed)" href="http://redmine.audacious-media-player.org/issues/2">#2</a> is probably a bug in, or limitation of, GDBus.</p> Audacious - Feature #559 (Closed): Multiplexed output / record while playinghttp://redmine.audacious-media-player.org/issues/5592015-07-05T19:42:29ZJohn Lindgrenjohn@jlindgren.net
<p>The absence of a "record" button was mentioned on the forum<sup><a href="#fn1">1</a></sup>. It doesn't make sense to add such a button at present, but a record-while-playing feature would actually be cool to have. We would have to implement output multiplexing (i.e. output to the primary output plugin and FileWriter simultaneously), but this shouldn't be that difficult; most of the infrastructure is there already.</p>
<p id="fn1" class="footnote"><sup>1</sup> <a class="external" href="http://redmine.audacious-media-player.org/boards/1/topics/1660">http://redmine.audacious-media-player.org/boards/1/topics/1660</a></p> Audacious - Bug #486 (Closed): Playlist manager missing from Win32 package (3.6-alpha1)http://redmine.audacious-media-player.org/issues/4862014-12-07T04:03:51ZJohn Lindgrenjohn@jlindgren.net
<p>Oops ... reminder to myself to include it in the next build.</p> Audacious - Feature #484 (Closed): [qtui] Missing playlist editor featureshttp://redmine.audacious-media-player.org/issues/4842014-12-01T19:24:15ZJohn Lindgrenjohn@jlindgren.net
<p>The playlist editor in the Qt UI is missing some important features:<br />- Selection of multiple entries<br />- Copy and paste<br />- Drag and drop</p> Audacious - Bug #425 (Closed): Certain .m4a files do not playhttp://redmine.audacious-media-player.org/issues/4252014-04-01T15:26:46ZJohn Lindgrenjohn@jlindgren.net
<p>As mentioned on the forum [1], some .m4a files do not play in Audacious. The example file provided [2] can be played fine using VLC or ffplay.</p>
<p>[1] <a class="external" href="http://redmine.audacious-media-player.org/boards/1/topics/1117">http://redmine.audacious-media-player.org/boards/1/topics/1117</a><br />[2] <a class="external" href="http://redmine.audacious-media-player.org/attachments/download/354/Jimi%20Hendrix%20-%20Spanish%20Castle%20Magic.m4a">http://redmine.audacious-media-player.org/attachments/download/354/Jimi%20Hendrix%20-%20Spanish%20Castle%20Magic.m4a</a></p> Audacious - Bug #392 (Closed): Non-ASCII characters cannot be used on command line in Windowshttp://redmine.audacious-media-player.org/issues/3922014-01-10T06:48:25ZJohn Lindgrenjohn@jlindgren.net
<p>As noticed here [1], filenames with non-ASCII characters cannot be opened via the command line in Windows. Opening the same files from the Open dialog works correctly.</p>
<p>Technical details:</p>
<p>This is due to GLib's crazy definition of "filename encoding", which means the system locale on every system except Windows, but UTF-8 on Windows [2]. When we pass G_OPTION_ARG_FILENAME_ARRAY to GLib to get our list of filenames from the command line, we are treating these filenames as though they are in the system locale. This is a correct assumption on most systems, but on Windows, GLib has already converted those filenames to UTF-8. We happily go and run the conversion a second time, which (for example) turns "ú" (FAh in CP1252, C3h BAh in UTF-8) into "ú" (C3h 83h C2h BAh in UTF-8).</p>
<p>[1] <a class="external" href="http://redmine.audacious-media-player.org/boards/1/topics/1018">http://redmine.audacious-media-player.org/boards/1/topics/1018</a></p>
<p>[2] Particularly ironic since UTF-8 is one of the few encodings you <strong>cannot</strong> use for filenames in Windows. You can use CP1252 and most other legacy encodings, or you can use UTF-16, but not UTF-8.</p> Audacious - Bug #193 (Closed): fsync() should not be called when closing read-only fileshttp://redmine.audacious-media-player.org/issues/1932012-10-06T21:27:07ZJohn Lindgrenjohn@jlindgren.net
<p>Under Linux, fsync() returns an error when the file is on a read-only medium such as a CD-ROM. We should prevent this error by not calling fsync() when we have opened a file in read-only mode.</p> Audacious - Bug #192 (Closed): Loading album art can make UI unresponsivehttp://redmine.audacious-media-player.org/issues/1922012-10-06T21:20:32ZJohn Lindgrenjohn@jlindgren.net
<p>Currently, album art is loaded in the main thread, blocking the UI code from running. On a slow storage medium or over a network, this can make Audacious unresponsive and/or slow to start. For 3.4, we should implement a queued request system where a plugin can call a non-blocking function to request an image and then listen for a hook to be called when the image has been loaded.</p> Audacious - Feature #101 (Closed): gio: Add error reportinghttp://redmine.audacious-media-player.org/issues/1012012-04-21T18:52:08ZJohn Lindgrenjohn@jlindgren.net
<p>Currently we call many GIO functions with the (GError**) parameter set to NULL. This needs to be fixed so that we can actually print error messages when something goes wrong. Once this is done, we can do further testing and consider enabling the gio plugin by default (which will close <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add support for smb:// URI's (Closed)" href="http://redmine.audacious-media-player.org/issues/30">#30</a> and <a class="issue tracker-2 status-5 priority-4 priority-default closed" title="Feature: Add support for ftp:// URIs (Closed)" href="http://redmine.audacious-media-player.org/issues/81">#81</a>).</p>