Redmine: Issueshttp://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402018-01-08T02:14:58ZRedmine
Redmine Audacious - Bug #765 (Closed): Gnome Shortcut doesn't work anymore in Gnome 3.26 (thanks Gnome fo...http://redmine.audacious-media-player.org/issues/7652018-01-08T02:14:58ZJean-Alexandre Anglès d'Auriacjagw40k@free.fr
<p>Gnome Shortcut doesn't work in Gnome 3.26 anymore because Gnome people discovered that they didn't follow their own documentation, and rather than change the documentation to change the current implementation, they decided to change the implementation to match the documentation, and break all the existing apps in the process. THANKS GNOME. See <a class="external" href="https://bugzilla.gnome.org/show_bug.cgi?id=781326">https://bugzilla.gnome.org/show_bug.cgi?id=781326</a> for more details.</p>
<p>Instead of listening on org.gnome.SettingsDaemon, the plugin must now listen on org.gnome.SettingsDaemon.MediaKeys</p>
<p>According to <a class="external" href="https://bugzilla.gnome.org/show_bug.cgi?id=781326#c8">https://bugzilla.gnome.org/show_bug.cgi?id=781326#c8</a> , the change has been backported into old versions of Gnome, but in order to make sure not to break anything for users of older versions of Gnome, the proposed patch first try to use org.gnome.SettingsDaemon, and only switch to the org.gnome.SettingsDaemon.MediaKeys if the old name fails. Using only the new name does create failure for some user according to this: <a class="external" href="https://github.com/gkarsay/parlatype/commit/28f05bcd3d0cde7582ffdaf2c4eb92b557528d8e">https://github.com/gkarsay/parlatype/commit/28f05bcd3d0cde7582ffdaf2c4eb92b557528d8e</a></p>
<p>The patch is really simple and should be easy to read, I would happily modify it based on any feedback though. Also I made the patch using git diff but I can use any method more convenient for the Audacious devs.</p> Audacious - Bug #312 (Rejected): Incoherent use of the app_icon parameter in the notificationshttp://redmine.audacious-media-player.org/issues/3122013-06-30T18:47:49ZJean-Alexandre Anglès d'Auriacjagw40k@free.fr
<p>In the current version of the Notify plugin, there are three possible stat for the app_icon parameter :<br />- If Audacious is not currently playing, it is set to "audacious" <br />- If Audacious is currently playing, and there is no retrieved cover, it is set to "audio-x-generic" <br />- If Audacious is currently playing, and there is a retrieved cover, it is set to NULL.</p>
<p>Now, the specification defines app_icon as : “The optional program icon of the calling application.”. Hence, I think "audacious" is the most sensible option, and the two others are not relevant.</p>
<p>The specification also explicitly mention that :<br />“An implementation which only displays one image or icon must choose which one to display using the following order:<br /><del>"image-data" <br /></del>"image-path" <br />- app_icon parameter<br />- for compatibility reason, "icon_data"”, so there should be no drawback to not having app_icon not set to NULL even when displaying a cover.</p> Audacious - Feature #206 (Closed): Add better integration in Gnome-Shell via the notify pluginhttp://redmine.audacious-media-player.org/issues/2062012-11-09T17:30:01ZJean-Alexandre Anglès d'Auriacjagw40k@free.fr
<p>Hi.</p>
<p>I modified the notify plugin to provide better integration into Gnome-Shell, mainly by copying the behavior of Rhythmbox's notifications.<br />What I did was mainly to make the notifications persistent and to add actions onto them. This makes the notification act in some way like the old status icon, and allow to control Audacious even when the screen is locked, if the option is activated.</p>
<p>The result can be viewed here :<br /><a class="external" href="http://www.youtube.com/watch?v=m8T84TVH234">http://www.youtube.com/watch?v=m8T84TVH234</a></p>
<p>The code is available here :<br /><a class="external" href="http://buuficontheme.free.fr/notify-gs.tar.gz">http://buuficontheme.free.fr/notify-gs.tar.gz</a></p>
<p>I currently have two issues :<br />- I have relatively frequent Gnome-Shell crashes that seems to be related to the use of this plugin, but I've been unable to track down what exactly is causing them<br />- I don't display the album art. The problem here is that audgui_pixbuf_for_current() returns a GdkPixmap, that is then used with notify_notification_set_image_from_pixbuf() to set it in the notification, but this has terrible performance. I don't know whether is it inherent to the design or bad implementation on libnotify or gnome-shell, but there is a 2 to 4 second lag before the notification is updated. On the other hand, Rhythmbox is just using notify_notification_set_hint() with the "image_path" hint that provides the path to the file, and this solution doesn't introduce any lag. To fix that, I should either transform the gdkpixbuf into a file, or see with upstream if notify_notification_set_image_from_pixbuf() can be improved.</p>