http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402022-07-15T22:54:45ZRedmineAudacious - Feature #1173: Add HLS supporthttp://redmine.audacious-media-player.org/issues/1173?journal_id=43562022-07-15T22:54:45ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>I added the HLS stream detection. Thanks!<br /><a class="external" href="https://github.com/audacious-media-player/audacious-plugins/commit/60dcba4dae05000a9a2dfa501e42ad30fd37115e">https://github.com/audacious-media-player/audacious-plugins/commit/60dcba4dae05000a9a2dfa501e42ad30fd37115e</a></p>
<p>I think the rest of the extended M3U needs more work, since right now the metadata that gets read will be lost as soon as the playlist is refreshed.<br />(There's not currently a good way to handle metadata that comes from the playlist vs. the song file.)</p> Audacious - Feature #1173: Add HLS supporthttp://redmine.audacious-media-player.org/issues/1173?journal_id=43572022-07-16T18:28:40ZJim Turnerturnerjw784@yahoo.com
<ul><li><strong>File</strong> <a href="/attachments/989/playlist-data.cc.diff">playlist-data.cc.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/989/playlist-data.cc.diff">playlist-data.cc.diff</a> added</li></ul><p>Thanks! I lightly tested w/the forum poster's stream, and a non-HLS extd-m3u playlist and it seems to work (except for the buffer-underrunning audio-issue I mentioned - NOTE: raising the audio buffering does not seem to affect).</p>
<p>Now, as far as the extended-m3u metadata issue, I had that working in some other code, so I have now merged that here in the attached patch for playlist-data.cc that seems to address the metadata-refresh issue here now too (Note: the playlist metadata tags are overwritten by metadata embedded in the entry IFF the entry has metadata (which is what I would expect to happen, especially if the entry is a streaming station). Please review before closing out this issue!</p>
<p>Also see and close out as dup. my (still open) previous request regarding this issue: Feature <a class="issue tracker-2 status-1 priority-5 priority-high3" title="Feature: Extended M3U support (New)" href="http://redmine.audacious-media-player.org/issues/875">#875</a>, which I did not remember until after I filed this one, which also includes now outdated patches similar to these.</p>
<p>Thanks,</p>
<p>Jim</p> Audacious - Feature #1173: Add HLS supporthttp://redmine.audacious-media-player.org/issues/1173?journal_id=43582022-07-17T17:22:26ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Category</strong> set to <i>plugins/m3u</i></li><li><strong>Subject</strong> changed from <i>Add extended-M3U playlist & HLS support</i> to <i>Add HLS support</i></li><li><strong>Affects version</strong> <i>4.2</i> added</li></ul><p>This patch (playlist-data.cc.diff) introduces a new bug: if I edit the tag of a playlist entry and clear e.g. the Title field, then Save, my changes are not reflected in the playlist. The old title is still displayed until I remove and re-add the playlist entry.</p>
<p>My comment from <a class="issue tracker-2 status-1 priority-5 priority-high3" title="Feature: Extended M3U support (New)" href="http://redmine.audacious-media-player.org/issues/875">#875</a> still applies:</p>
<blockquote>
<p>We need a way (for example, a flag in the Tuple class) to mark info that came from a playlist (cuesheet or extended M3U) rather than from the audio file itself.</p>
</blockquote>
<p>Let's continue the extended M3U discussion under the original ticket (<a class="issue tracker-2 status-1 priority-5 priority-high3" title="Feature: Extended M3U support (New)" href="http://redmine.audacious-media-player.org/issues/875">#875</a>). I'll mark this one as complete. Thanks again for the HLS patch.</p> Audacious - Feature #1173: Add HLS supporthttp://redmine.audacious-media-player.org/issues/1173?journal_id=43602022-07-17T17:35:09ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul>