http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402023-02-18T12:58:11ZRedmineAudacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45022023-02-18T12:58:11Zjesus2099 💗
<ul></ul><p>I am on Raspbarry Pi OS (Raspbian/Debian) 10 Xfce.</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45032023-02-18T15:47:16ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Have you tried a newer version? 3.10.1 is quite old now, and not supported any more.</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45082023-02-22T07:32:54ZArtem S. Tashkinov
<ul></ul><p>I'm using Audacious 4.3-beta1, GTK2 version.</p>
<p>Ctrl+F doesn't find tracks by their filenames.</p>
<p>Ctrl+J finds them.</p>
<p>(I'm also curious why the Qt version doesn't have the Ctrl+J (Jump to Song) dialog).</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45102023-02-27T19:08:30ZThomas Langethomas-lange2@gmx.de
<ul></ul><p>With Qt the "Jump to Song" dialog does not search in file names though. This is only the case for GTK.<br />The dialog may be useful anyway, so I approve adding it.</p>
<p>@John: Is it missing in qtui because our custom Ctrl+F search is supposed to be better? Or simply because of historical reasons? The dialog was long missing in the Winamp interface as well.</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45112023-02-28T01:51:04ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Ctrl+F search was supposed to combine Jump to Song and the previous playlist search in a way that was better integrated into the UI and reused code better (hence filtering the existing playlist display rather than a separate window).</p>
<p>I had hoped to reuse the same playlist widget (with filtering) for a popup search/jump to song window in the Qt Winamp interface but never had the time to do it.</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45122023-02-28T20:46:10ZThomas Langethomas-lange2@gmx.de
<ul></ul><p><a class="user active" href="/users/3655">jesus2099 💗</a>: In my opinion "CTRL+F" should search in the potentially visible (scrollable) content, like a web browser does. So if the file name column is not shown in the playlist, I would not expect it to be searched.</p>
<p>@John: Regarding the "Jump to Song" dialog: Do you think it is redundant to offer it in qtui? It's already there in libaudqt, but only used in the Qt Winamp interface.<br />Implementing the GTK "Jump to Time" dialog would also be possible. I can take care of this if you want. Feature parity between GTK/Qt should always be useful. :)</p>
<pre>
diff --git a/src/qtui/menus.cc b/src/qtui/menus.cc
index bee13e1be..89c460f17 100644
--- a/src/qtui/menus.cc
+++ b/src/qtui/menus.cc
@@ -161,6 +161,8 @@ QMenuBar * qtui_build_menubar(QWidget * parent)
audqt::MenuCommand(
{N_("Song _Info ..."), "dialog-information", "Ctrl+I"},
audqt::infowin_show_current),
+ audqt::MenuCommand({N_("_Jump to Song ..."), "go-jump", "Ctrl+J"},
+ audqt::songwin_show),
audqt::MenuSep(),
audqt::MenuCommand({N_("Set Repeat Point _A"), nullptr, "Ctrl+1"},
set_ab_repeat_a),
</pre> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45132023-03-01T00:11:48ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>It seems redundant to me. Ctrl+F already provides a means to search for a track and play it.</p>
<p>Personally I'm not opposed to searching by filename as well (even if the column is hidden).</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45142023-03-01T13:37:52ZArtem S. Tashkinov
<ul></ul><p>Ctrl + J is <strong>hugely</strong> important for me.</p>
<p>Sometimes you don't quite remember how the track is called, so you enter something and it shows a short list of tracks which is easy to navigate.</p>
<p>Ctrl + F on the other hand jumps between tracks in a very long list (I have over 5000 tracks), so finding a track you don't quite remember becomes near impossible.</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45152023-03-01T13:44:03ZArtem S. Tashkinov
<ul></ul><p>There's another use for this dialog.</p>
<p>Imagine you want to create a new playlist based on certain obscure criterion which doesn't quite work for any sort mode.</p>
<p>You enter a search string, you get a list of tracks, you select them and drag them to a new playlist.</p>
<p>Actually, actually, here's a new better idea.</p>
<p>Instead of a dedicated dialog what about a search field which <em>filters</em> the tracks in the current playlist dynamically?</p>
<p>So, once you enter a search string, instead of seeing the entire playlist you only get the tracks that match the search string.</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45162023-03-01T14:28:28ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><blockquote>
<p>Instead of a dedicated dialog what about a search field which filters the tracks in the current playlist dynamically?</p>
</blockquote>
<p>That's what Ctrl-F does ...</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45172023-03-02T09:28:07ZArtem S. Tashkinov
<ul></ul><p>John Lindgren wrote:</p>
<blockquote><blockquote>
<p>Instead of a dedicated dialog what about a search field which filters the tracks in the current playlist dynamically?</p>
</blockquote>
<p>That's what Ctrl-F does ...</p>
</blockquote>
<p>It actually does. Well, then, it's all good, just please allow to search for filenames :-)</p> Audacious - Feature #1204: Ctrl+F playlist search should also search in file nameshttp://redmine.audacious-media-player.org/issues/1204?journal_id=45182023-03-04T22:15:23ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>Target version</strong> set to <i>4.3</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Category</strong> set to <i>plugins/qtui</i></li></ul><p>Fixed for the Qt interface with <a class="external" href="https://github.com/audacious-media-player/audacious-plugins/commit/82ecc280e5a965e2077feae4a715e0e4a8dadce1">https://github.com/audacious-media-player/audacious-plugins/commit/82ecc280e5a965e2077feae4a715e0e4a8dadce1</a>.</p>