http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402023-03-13T15:46:50ZRedmineAudacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45192023-03-13T15:46:50ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>So the artist field is not shown, is that the issue?</p>
<p>Is there a non-UTF-8 character encoding in use here? What are your character set detection settings?</p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45202023-03-13T16:26:09ZArtem S. Tashkinov
<ul></ul><blockquote>
<p>So the artist field is not shown, is that the issue?</p>
</blockquote>
<p>Exactly.</p>
<blockquote>
<p>Is there a non-UTF-8 character encoding in use here? What are your character set detection settings?</p>
</blockquote>
<p>This looks ASCII to me, you can download the file after all.</p>
<p>My settings:</p>
<p>Auto character encoding detector for: None</p>
<p>Fallback character encoding: CP1251 - setting it to an empty field changes nothing.</p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45212023-03-13T16:27:31ZArtem S. Tashkinov
<ul></ul><p>It's extremely unlikely that the title and artist tags have different encoding settings, yet the title is parsed and shown, and the artist is not.</p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45242023-03-17T21:03:55ZJim Turnerturnerjw784@yahoo.com
<ul><li><strong>File</strong> <a href="/attachments/1012/OnTheRun_mp3_data.odt">OnTheRun_mp3_data.odt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1012/OnTheRun_mp3_data.odt">OnTheRun_mp3_data.odt</a> added</li><li><strong>File</strong> <a href="/attachments/1011/id3v24.diff">id3v24.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/1011/id3v24.diff">id3v24.diff</a> added</li></ul><p>It appears (at least in id3v24 tags) that a file can contain "empty" tags (zero-length values), at least this is the case here. I believe this code-change will fix this. I've also attached an "od -c" dump of the top of this file (Libreoffice ODF) showing the tags (in blue). The 2 empty tags (WOAF & WOAR) are shown in red, and the "missing" artist tag (TPE1) and value are shown in green following the 2 blank ones. Current Audacious code stops on the 1st empty one (thus omitting the artist.</p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45262023-03-18T03:03:06ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>ID3v2.4 says "A frame must be at least 1 byte big, excluding the header." So the tag is corrupt (probably corrupted by some broken tag editing software). The invalid frames in question, by the way, are:</p>
<ul>
<li>WOAF - Official audio file webpage</li>
<li>WOAR - Official artist/performer webpage</li>
<li>WOAS - Official audio source webpage</li>
</ul>
<p>It makes no sense to have an "empty URL" in the ID3 tag.</p>
<p>Now, it may be fine to just skip over the invalid frames. I'll look more closely at your patch and apply it if it looks safe. Thanks for looking into this.</p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45272023-03-18T04:19:13ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>Fixed by:<br /><a class="external" href="https://github.com/audacious-media-player/audacious/commit/2a961489a8ae43d290dde6aa9375e9607775c8c9">https://github.com/audacious-media-player/audacious/commit/2a961489a8ae43d290dde6aa9375e9607775c8c9</a></p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45282023-03-20T08:16:53ZArtem S. Tashkinov
<ul></ul><p>Thanks a ton for the patch, it's fixed all such files.</p> Audacious - Bug #1205: MP3 tags are not fully readhttp://redmine.audacious-media-player.org/issues/1205?journal_id=45462023-04-29T21:22:17ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>Target version</strong> set to <i>4.3.1</i></li></ul>