http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402012-08-12T08:40:00ZRedmineAudacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5052012-08-12T08:40:00ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Affects version</strong> <i>3.3.1</i> added</li><li><strong>Affects version</strong> deleted (<del><i>3.4</i></del>)</li></ul><p>The changes to menus.c look good. I don't understand the changes to ui_gtk.c, can you explain their purpose?</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5072012-08-12T23:11:05Zanonymous passwordM8R-q174a21@mailinator.com
<ul></ul><p>The changes to ui_gtk.c remove hard-coded shortcuts (because they could conflict with users' choices and can be duplicated in configuration if the user so chooses) and allow text entry widgets to receive text-editing shortcuts at a higher priority than user-defined shortcuts.</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5082012-08-13T02:56:28ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>I don't think we can accept a patch that removes the legacy playback shortcuts (z, x, c, v, b); it would inconvenience too many users who are used to these shortcuts.</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5092012-08-13T04:30:48Zanonymous passwordM8R-q174a21@mailinator.com
<ul><li><strong>File</strong> <a href="/attachments/113/change_shortcuts_v7.patch">change_shortcuts_v7.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/113/change_shortcuts_v7.patch">change_shortcuts_v7.patch</a> added</li></ul><p>Sure thing; I wasn't sure what behavior was preferred. Fixed to retain those shortcuts, but allow them to be overridden by other functions if the user explicitly sets them.</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5162012-08-14T02:37:43ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Okay, that looks better. Please explain this logic, though:<br /><pre>if ((event->keyval == ' ' && ! (event->state & GDK_CONTROL_MASK)) && GTK_IS_TREE_VIEW (gtk_window_get_focus ((GtkWindow *) widget)))</pre></p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5202012-08-14T03:17:19Zanonymous passwordM8R-q174a21@mailinator.com
<ul></ul><p>That's a direct consequence of needing to allow key_press_cb in audacious's libaudgui/list.c to disable GTK's 'spacebar activates the selected row in a gtktreeview' behavior. It checks if the focused widget is a list view, if the key is the spacebar, and if ctrl is not held; if all those are true, it considers the hotkey unhandled so that the treeview (rather than the window) can handle it to cancel that action.</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5212012-08-15T01:26:54ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>If I understand you correctly, you are saying that gtk_window_propagate_key_event() would somehow bypass key_press_cb() in libaudgui/list.c. Is that right?</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5222012-08-15T01:51:35ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>I just tried running Audacious with your patch. The spacebar doesn't work for pause any more; this would be a major regression.</p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=5232012-08-15T01:54:43ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Also, I did not notice any change in behavior when commenting out these lines, so I'm still not sure what they are meant to accomplish:<br /><pre> if ((event->keyval == ' ' && ! (event->state & GDK_CONTROL_MASK)) && GTK_IS_TREE_VIEW (gtk_window_get_focus ((GtkWindow *) widget)))
return FALSE;</pre></p> Audacious - Feature #163: Configurable hotkeyshttp://redmine.audacious-media-player.org/issues/163?journal_id=9402013-04-11T03:22:43ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Rejected</i></li></ul><p>Closing due to lack of response.</p>