http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402013-07-31T20:32:51ZRedmineAudacious - Bug #326: Buffer size too small for HVSC songlengths dbhttp://redmine.audacious-media-player.org/issues/326?journal_id=11332013-07-31T20:32:51ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>What type of line are we talking about here, a line of text? 1024 bytes seems like it should be more than long enough.</p> Audacious - Bug #326: Buffer size too small for HVSC songlengths dbhttp://redmine.audacious-media-player.org/issues/326?journal_id=11342013-07-31T20:49:18ZMichael Schwendt
<ul></ul><p>$ wc -L Songlengths.txt <br />1312 Songlengths.txt</p>
<p>It's a INI-style database file with key=value pairs, and since some sidtune files contain lots of sub-songs (or sound effects), the "value" can get rather large.</p> Audacious - Bug #326: Buffer size too small for HVSC songlengths dbhttp://redmine.audacious-media-player.org/issues/326?journal_id=11362013-07-31T21:02:37ZMatti Tiainen
<ul></ul><p>Ok, I tried to reproduce the issue again with the original XS_BUF_SIZE 1024, but could not actually trigger any other problems than this warning in audacious log:</p>
<p>Invalid MD5-hash in SongLengthDB file '/Volumes/Shared/C64Music/DOCUMENTS/Songlengths.txt' line #17712!<br />Invalid MD5-hash in SongLengthDB file '/Volumes/Shared/C64Music/DOCUMENTS/Songlengths.txt' line #17715!</p>
<p>Which is caused by the songlengths for these SIDS:</p>
<p>; /MUSICIANS/B/Bond_Alan/Randomly_generated_music_2_BASIC.sid<br />; /MUSICIANS/B/Bond_Alan/Randomly_generated_music_BASIC.sid</p>
<p>So probably my memory fails and I just wanted to fix the warnings tweaking SID plugin (I did some initial quick and dirty port of the SID plugin for sidplayfp before the "official" support arrived) or the issue got fixed some other way.</p>
<p>Sorry for the noise :P</p> Audacious - Bug #326: Buffer size too small for HVSC songlengths dbhttp://redmine.audacious-media-player.org/issues/326?journal_id=11382013-07-31T22:17:59ZMichael Schwendt
<ul></ul><p>You may have misinterpreted my previous comment. A buffer size of 1024 is <em>not</em> enough, because the two longest lines in the file are 1312 characters plus end-of-line delimiters. The two entries you've mentioned are exactly those very long lines. For example:</p>
<p>; /MUSICIANS/B/Bond_Alan/Randomly_generated_music_2_BASIC.sid<br />24a19792bb845f93dac18ccd84d66476=0:31 0:50 1:02 0:45 0:57 0:50 0:45 0:46 1:09 1:04 1:04 0:43 0:43 0:46 0:31 1:15 0:50 0:54 1:09 1:04 1:09 1:02 0:58 1:04 0:39 0:57 0:46 0:46 0:43 0:52 0:36 1:04 0:43 0:45 0:59 1:04 0:43 0:58 0:59 0:46 0:52 0:58 0:58 0:52 0:39 0:50 0:50 0:58 0:46 0:41 0:39 0:45 1:02 0:58 1:02 0:52 0:46 0:57 0:54 0:52 0:39 1:04 0:46 0:50 0:39 1:04 0:52 0:52 0:43 0:50 0:58 0:50 0:45 0:57 0:46 1:04 0:58 0:45 1:09 1:02 0:54 0:39 0:31 1:09 0:43 0:52 1:15 0:50 0:52 0:43 1:04 1:09 0:59 0:43 0:45 1:04 0:31 0:45 1:09 0:58 0:57 0:41 0:57 0:46 0:39 1:04 0:57 1:09 0:57 1:09 0:45 0:43 0:43 0:50 0:50 0:57 1:09 1:04 1:02 1:02 0:50 0:59 0:58 0:45 0:45 0:46 1:04 1:09 0:41 0:57 0:43 1:15 1:09 0:45 0:45 0:31 0:52 0:57 0:50 0:46 0:58 0:46 0:45 0:50 0:41 0:43 1:04 1:02 0:36 0:41 0:57 0:52 1:04 0:43 0:43 0:52 0:58 0:52 0:58 1:15 0:39 0:35 0:43 0:54 0:46 0:50 0:52 0:52 0:46 0:43 0:58 0:57 1:09 0:35 0:43 1:08 1:07 0:58 0:57 0:58 0:54 0:31 0:35 0:45 0:50 0:45 0:58 0:54 1:04 0:45 0:43 0:54 0:39 0:58 0:50 0:58 0:57 0:52 0:39 1:07 0:52 0:52 0:52 1:04 0:45 0:58 0:59 0:57 0:58 1:04 0:35 0:43 0:35 0:46 0:50 1:09 0:57 1:04 0:52 0:45 0:43 1:15 0:39 0:39 0:45 0:52 0:57 0:41 0:52 0:57 0:45 0:43 1:02 0:43 0:50 0:50 0:57 1:04 0:35 0:50 0:35 0:46 0:50 0:57 0:41 0:39 0:39 0:58 0:41 1:09 0:57 1:02 1:07 0:39 1:09 0:46</p> Audacious - Bug #326: Buffer size too small for HVSC songlengths dbhttp://redmine.audacious-media-player.org/issues/326?journal_id=11442013-08-03T02:11:56ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>3.4.1</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Affects version</strong> <i>3.4</i> added</li><li><strong>Affects version</strong> deleted (<del><i>3.4.1</i></del>)</li></ul><p><a class="external" href="https://github.com/audacious-media-player/audacious-plugins/commit/064d063a43a6120a494565bc8d367c67e04dfe70">https://github.com/audacious-media-player/audacious-plugins/commit/064d063a43a6120a494565bc8d367c67e04dfe70</a></p>