http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402013-08-24T18:42:34ZRedmineAudacious - Bug #334: [PATCH] file writer flac does not write tagshttp://redmine.audacious-media-player.org/issues/334?journal_id=11692013-08-24T18:42:34ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>This is a good start, but making flac_metadata static introduces another leak. See if you can figure out why.</p>
<p>Edit: Never mind, the leak I'm thinking of shouldn't happen in normal operation.</p> Audacious - Bug #334: [PATCH] file writer flac does not write tagshttp://redmine.audacious-media-player.org/issues/334?journal_id=11702013-08-24T19:07:42ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Affects version</strong> <i>3.4</i> added</li><li><strong>Affects version</strong> deleted (<del><i>3.4.1, 3.5</i></del>)</li></ul><p><a class="external" href="https://github.com/audacious-media-player/audacious-plugins/commit/6e050db79c35cb4d4e1e51aa2d79b0d7bd5972ad">https://github.com/audacious-media-player/audacious-plugins/commit/6e050db79c35cb4d4e1e51aa2d79b0d7bd5972ad</a><br /><a class="external" href="https://github.com/audacious-media-player/audacious-plugins/commit/d3b127b53e7f78b73e0555d581af84c8ec545320">https://github.com/audacious-media-player/audacious-plugins/commit/d3b127b53e7f78b73e0555d581af84c8ec545320</a></p> Audacious - Bug #334: [PATCH] file writer flac does not write tagshttp://redmine.audacious-media-player.org/issues/334?journal_id=11712013-08-24T19:09:14ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>James Buren wrote:</p>
<blockquote>
<p>Also, the compression level is now set to 8, the maximum.</p>
</blockquote>
<p>DO NOT EVER add arbitrary changes like this to an otherwise legitimate bug-fix patch.</p> Audacious - Bug #334: [PATCH] file writer flac does not write tagshttp://redmine.audacious-media-player.org/issues/334?journal_id=11722013-08-24T19:10:15ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>James Buren wrote:</p>
<blockquote>
<p>5) FLAC vorbis comments should be in uppercase, as that is what the official encoder<br />does.</p>
</blockquote>
<p>Actually, Vorbis comments are case-insensitive, so either way is fine.</p>