http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402016-05-30T05:19:57ZRedmineAudacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24092016-05-30T05:19:57ZJim Turnerturnerjw784@yahoo.com
<ul></ul><p>I actually used the Search tool for the 1st time the other day and I SECOND this request!</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24252016-07-10T06:29:11ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Yes, this would make sense. A patch would be welcome.</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24652016-08-13T11:33:17ZPaul Franke
<ul><li><strong>File</strong> <a href="/attachments/592/search-tool-dnd.patch">search-tool-dnd.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/592/search-tool-dnd.patch">search-tool-dnd.patch</a> added</li></ul><p>I hope it is ok to post a patch this way.</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24662016-08-14T00:09:55ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li><li><strong>Target version</strong> set to <i>3.8</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Merged, thank you!</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24672016-08-14T02:37:04ZPaul Franke
<ul><li><strong>File</strong> <a href="/attachments/593/fix-dnd.patch">fix-dnd.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/593/fix-dnd.patch">fix-dnd.patch</a> added</li></ul><p>Great, thank you. Unfortunately the patch supporting lists that are only a drag source prevents dragging more than one selected search-tool result to a playlist. Fix attached.</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24682016-08-14T07:26:25ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>That's rather odd ... anyway, thanks for the fix, applied.</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24692016-08-14T15:40:45ZPaul Franke
<ul><li><strong>File</strong> <a href="/attachments/594/fix-dnd-really.patch">fix-dnd-really.patch</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/594/fix-dnd-really.patch">fix-dnd-really.patch</a> added</li></ul><p>This took me some time tracking down, but my last fix is rubbish.</p>
<p>Multiple selections of lists that are only a drag source get mistakenly cleared by button_release_cb because of model->frozen = true. model->frozen is set false by drag_motion. But the drag-motion signal seems to be fired for destinations only. A quick search on gtk drag-and-drop signal order revealed chapter three of <a class="external" href="http://www.compsci.hunter.cuny.edu/~sweiss/course_materials/csci493.70/lecture_notes/GTK_dragndrop.pdf">http://www.compsci.hunter.cuny.edu/~sweiss/course_materials/csci493.70/lecture_notes/GTK_dragndrop.pdf</a>.</p>
<p>Fix attached.</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24702016-08-14T18:27:36ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><p>Excellent find, thanks. I looked briefly at the logic last night trying to figure out what was really going on, but this code is very subtle; evidently even its author has trouble understanding it any more. :(</p> Audacious - Feature #621: Drag & Drop from Search tool into playlistshttp://redmine.audacious-media-player.org/issues/621?journal_id=24712016-08-14T22:09:44ZPaul Franke
<ul></ul><p>Thank you very much merging that all so fast.</p>