http://redmine.audacious-media-player.org/http://redmine.audacious-media-player.org/welcome/favicon.ico?15159353402018-12-26T07:49:28ZRedmineAudacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31682018-12-26T07:49:28ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Target version</strong> deleted (<del><i>3.10.1</i></del>)</li><li><strong>Affects version</strong> deleted (<del><i>3.10.1</i></del>)</li></ul> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31722018-12-30T12:14:56ZMichael Schwendt
<ul></ul><p>My advice: Don't "switch", but introduce a separate input plugin for a new MOD backend lib.</p>
<p>The rationale is simple. Hardly any MOD player lib is perfect. There are many thousands of MOD files. (Side-note: when I use the term "MOD" I don't refer to only the ancient .mod files from the late 80's and early 90's, but also the many derivatives that have been published later.) Typically, authors of new MOD playing libs start with a new set of test files, such as their favorite ones and new problematic ones pointed out in bug reports. A lib would need to be really popular for more users to give it a try and test it with old and new files in their own mod file collections.</p>
<p>Audacious runs fine with multiple MOD input plugins installed. Users may choose to disable individual plugins. No harm is done, if keeping alternative input plugins for some time.</p>
<p>About XMP and its plugin for Audacious: The plugin has been ported to Audacious 3 a long time ago and continues to work fine. I'm not aware of any immediate maintenance requirements. Libxmp is in a fine state and continues to receive fixes for problematic files when they come up. I don't think it supports the .dsm format of your test file. In modplug 0.8.9, some of the samples sound slightly out of tune here.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31732018-12-30T22:59:43ZMichael Schwendt
<ul></ul><p>Interestingly, the "problematic module" attached to this ticket crashes openmpt123.</p>
<p>Going through a dir of testmods, I've found a few that don't play correctly (probably because Soundtracker detection isn't easy and some of the original mods are available as versions converted to Protracker) and one file that isn't recognized. Had files a modplug bug about it in 2011: <a class="external" href="https://sourceforge.net/p/modplug-xmms/bugs/13/">https://sourceforge.net/p/modplug-xmms/bugs/13/</a></p>
<blockquote>
<p>necros_-_spatial_distortion.dsm</p>
</blockquote>
<pre>
$ openmpt123 necros_-_spatial_distortion.dsm
openmpt123 v0.4.0, libopenmpt 0.4.0+r11103.pkg (OpenMPT 1.28.01.00 https://source.openmpt.org/svn/openmpt/tags/libopenmpt-0.4.0@11103 (2018-12-23T13:06:52.605038Z) clean-pkg)
Copyright (c) 2013-2018 OpenMPT developers <https://lib.openmpt.org/>
/usr/include/c++/8/bits/stl_vector.h:932: std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::operator[](std::vector<_Tp, _Alloc>::size_type) [with _Tp = OpenMPT::ModCommand; _Alloc = std::allocator<OpenMPT::ModCommand>; std::vector<_Tp, _Alloc>::reference = OpenMPT::ModCommand&; std::vector<_Tp, _Alloc>::size_type = long unsigned int]: Assertion '__builtin_expect(__n < this->size(), true)' failed.
Aborted (core dumped)
</pre> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31742018-12-31T04:23:28ZJonathan Rubenstein
<ul><li><strong>File</strong> <a href="/attachments/765/openmpt123test-packages.txt">openmpt123test-packages.txt</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/765/openmpt123test-packages.txt">openmpt123test-packages.txt</a> added</li></ul><p>Michael Schwendt wrote:</p>
<blockquote>
<p>Interestingly, the "problematic module" attached to this ticket crashes openmpt123.</p>
<p>Going through a dir of testmods, I've found a few that don't play correctly (probably because Soundtracker detection isn't easy and some of the original mods are available as versions converted to Protracker) and one file that isn't recognized. Had files a modplug bug about it in 2011: <a class="external" href="https://sourceforge.net/p/modplug-xmms/bugs/13/">https://sourceforge.net/p/modplug-xmms/bugs/13/</a></p>
<blockquote>
<p>necros_-_spatial_distortion.dsm</p>
</blockquote>
<p>[...]</p>
</blockquote>
<p>The problematic file I submitted doesn't crash openmpt123 for me, even using the same version<br /><pre>
openmpt123 v0.4.0, libopenmpt 0.4.0+r11103.pkg (OpenMPT 1.28.01.00 https://source.openmpt.org/svn/openmpt/tags/libopenmpt-0.4.0@11103 (2018-12-23T13:06:52.605038Z) clean-pkg)
Copyright (c) 2013-2018 OpenMPT developers <https://lib.openmpt.org/>
</pre><br />I've tested on a freshly installed and up to date Debian Testing amd64 install in a VM, with only the 'standard' (no graphics) packages and openmpt123. I've attached the result of a <code>dpkg-query -l</code> on the VM. It works on the host too, but I made the VM just to be sure it wasn't my specific configuration that resolves the crash.</p>
<p>I think a new lib alongside libmodplug would work fine as well, as Michael suggests.</p>
<a name="I-believe-libopenmpt-is-a-better-pick-But-regardless-deprecating-libmodplug-whether-by-replacing-it-completely-or-offering-an-additional-plugin-on-the-side-would-help-with-module-playback-immensely-regardless-of-which-one-is-chosen-since-they-are-still-actively-maintained"></a>
<h3 >I believe libopenmpt is a better pick. But regardless, deprecating libmodplug, whether by replacing it completely, or offering an additional plugin on the side, would help with module playback immensely regardless of which one is chosen, since they are still actively maintained.<a href="#I-believe-libopenmpt-is-a-better-pick-But-regardless-deprecating-libmodplug-whether-by-replacing-it-completely-or-offering-an-additional-plugin-on-the-side-would-help-with-module-playback-immensely-regardless-of-which-one-is-chosen-since-they-are-still-actively-maintained" class="wiki-anchor">¶</a></h3> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31752018-12-31T12:12:51ZMichael Schwendt
<ul></ul><p>Debian Testing is somewhat behind Fedora because of Red Hat's involvement with GCC.</p>
<pre>
$ rpm -q gcc-c++ libstdc++
gcc-c++-8.2.1-6.fc29.x86_64
libstdc++-8.2.1-6.fc29.x86_64
</pre>
<p>It's the only file that crashes openmpt123 so far while parsing the pattern data.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31782018-12-31T21:52:14ZJohn Lindgrenjohn@jlindgren.net
<ul></ul><blockquote>
<p>Chris Spiegel has created a working audacious plugin for this already</p>
</blockquote>
<p>I will wait for a request from Chris himself before "absorbing" his plugin into audacious-plugins. There is nothing wrong with him maintaining it out-of-tree if he prefers to do so (and it is probably less work for him that way).</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31962019-01-17T20:12:49ZJörn Heusipp
<ul></ul><p>(I am the libopenmpt maintainer)</p>
<blockquote><blockquote>
<p>necros_-_spatial_distortion.dsm</p>
</blockquote>
<p>Interestingly, the "problematic module" attached to this ticket crashes openmpt123.</p>
</blockquote>
<p>This is a libopenmpt bug, I added a ticket to our bug tracker at <a class="external" href="https://bugs.openmpt.org/view.php?id=1191">https://bugs.openmpt.org/view.php?id=1191</a> . We will release a fix ASAP.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=31982019-01-25T08:08:29ZJörn Heusipp
<ul></ul><blockquote><blockquote><blockquote>
<p>necros_-_spatial_distortion.dsm</p>
</blockquote>
<p>Interestingly, the "problematic module" attached to this ticket crashes openmpt123.</p>
</blockquote>
<p>This is a libopenmpt bug, I added a ticket to our bug tracker at <a class="external" href="https://bugs.openmpt.org/view.php?id=1191">https://bugs.openmpt.org/view.php?id=1191</a> . We will release a fix ASAP.</p>
</blockquote>
<p>Fixed in libopenmpt 0.4.2: <a class="external" href="https://lib.openmpt.org/libopenmpt/2019/01/22/security-updates-0.4.2-0.3.15-0.2.11253-beta37-0.2.7561-beta20.5-p13-0.2.7386-beta20.3-p16/">https://lib.openmpt.org/libopenmpt/2019/01/22/security-updates-0.4.2-0.3.15-0.2.11253-beta37-0.2.7561-beta20.5-p13-0.2.7386-beta20.3-p16/</a></p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=32082019-01-31T01:11:49ZChris Spiegel
<ul></ul><p>John Lindgren wrote:</p>
<blockquote><blockquote>
<p>Chris Spiegel has created a working audacious plugin for this already</p>
</blockquote>
<p>I will wait for a request from Chris himself before "absorbing" his plugin into audacious-plugins. There is nothing wrong with him maintaining it out-of-tree if he prefers to do so (and it is probably less work for him that way).</p>
</blockquote>
<p>Hi, I'm the author of this plugin. If you'd like it integrated with audacious-plugins, I'd be happy to move it there. It's 2-clause BSD licensed (I've just added an explicit LICENSE file to clarify this) so should be no issues there. If you're interested, let me know what I can do to help get it moved over.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=32092019-02-04T05:04:19ZChris Spiegel
<ul></ul><p>Chris Spiegel wrote:</p>
<blockquote>
<p>John Lindgren wrote:</p>
<blockquote><blockquote>
<p>Chris Spiegel has created a working audacious plugin for this already</p>
</blockquote>
<p>I will wait for a request from Chris himself before "absorbing" his plugin into audacious-plugins. There is nothing wrong with him maintaining it out-of-tree if he prefers to do so (and it is probably less work for him that way).</p>
</blockquote>
<p>Hi, I'm the author of this plugin. If you'd like it integrated with audacious-plugins, I'd be happy to move it there. It's 2-clause BSD licensed (I've just added an explicit LICENSE file to clarify this) so should be no issues there. If you're interested, let me know what I can do to help get it moved over.</p>
</blockquote>
<p>I decided to just take a look and see the level of effort needed to incorporate the plugin into audacious-plugins, and it was very easy. So I've now got a preliminary pull request at <a class="external" href="https://github.com/audacious-media-player/audacious-plugins/pull/68">https://github.com/audacious-media-player/audacious-plugins/pull/68</a>.</p>
<p>As noted in the pull request, I didn't replace the libmodplug plugin, instead just making it lower priority, so that anybody without access to libopenmpt can still have a tracker plugin.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=32312019-02-24T13:53:34ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>Subject</strong> changed from <i>Replace libmodplug with libopenmpt</i> to <i>Set OpenMPT priority above ModPlug</i></li></ul><p>The OpenMPT plugin is now merged but has lower priority than ModPlug for now. As discussed on GitHub, that's to give people a chance to test it out in the next release before dropping it on everyone as the default. I'm leaving this ticket open as a reminder to swap the priorities for the release after next.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=38852020-12-05T17:38:51ZJohn Lindgrenjohn@jlindgren.net
<ul><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li><li><strong>Status</strong> changed from <i>New</i> to <i>Closed</i></li></ul><p>OpenMPT is now the default in Git master.</p> Audacious - Feature #848: Set OpenMPT priority above ModPlughttp://redmine.audacious-media-player.org/issues/848?journal_id=39162020-12-21T21:02:44ZThomas Langethomas-lange2@gmx.de
<ul><li><strong>Target version</strong> set to <i>4.1</i></li></ul>