Bug #111

HSP file causes segfault

Added by Hanno Boeck over 5 years ago. Updated over 5 years ago.

Status:Closed Start date:May 12, 2012
Priority:Minor Due date:
Assignee:- % Done:

0%

Category:-
Target version:3.2.3
Affects version:3.2.2

Description

I get a crash with the attached HSP file. The source of the HSP file is here:
http://www.defacto2.net/file/detail/b04a9e

HSP is an audio format used by the HSC tracker and audacious should in theory support it with the adplug plugin.

1869AFRC.HSP - HSP sample file (520 Bytes) Hanno Boeck, May 12, 2012 23:45

Associated revisions

Revision 46ac4729
Added by John Lindgren over 5 years ago

adplug: Add bounds check to HSC decoder. Closes: #111.

Revision 7b99c53d
Added by John Lindgren about 5 years ago

adplug: Add bounds check to HSC decoder. Closes: #111.

History

#1 Updated by John Lindgren over 5 years ago

  • Target version set to 3.2.3
  • Status changed from New to Closed

The segfault is fixed:
https://github.com/audacious-media-player/audacious-plugins/commit/46ac472914d46efa9b976c5ea4c3ac19124c9192

This check of course makes the file fail to play. If it plays fine in other players, there may be another problem that needs fixing.

Also available in: Atom PDF