Audacious

The changes to ui_gtk.c remove hard-coded shortcuts (because they could conflict with users' choices and can be duplicated in configuration if the user so chooses) and allow text entry widgets to receive text-editing shortcuts at a higher priority than user-defined shortcuts.

I don't think we can accept a patch that removes the legacy playback shortcuts (z, x, c, v, b); it would inconvenience too many users who are used to these shortcuts.

Okay, that looks better. Please explain this logic, though:

if ((event->keyval == ' ' && ! (event->state & GDK_CONTROL_MASK)) && GTK_IS_TREE_VIEW (gtk_window_get_focus ((GtkWindow *) widget)))

That's a direct consequence of needing to allow key_press_cb in audacious's libaudgui/list.c to disable GTK's 'spacebar activates the selected row in a gtktreeview' behavior. It checks if the focused widget is a list view, if the key is the spacebar, and if ctrl is not held; if all those are true, it considers the hotkey unhandled so that the treeview (rather than the window) can handle it to cancel that action.

If I understand you correctly, you are saying that gtk_window_propagate_key_event() would somehow bypass key_press_cb() in libaudgui/list.c. Is that right?

I just tried running Audacious with your patch. The spacebar doesn't work for pause any more; this would be a major regression.

Also, I did not notice any change in behavior when commenting out these lines, so I'm still not sure what they are meant to accomplish:

    if ((event->keyval == ' ' && ! (event->state & GDK_CONTROL_MASK)) && GTK_IS_TREE_VIEW (gtk_window_get_focus ((GtkWindow *) widget)))
        return FALSE;