Project

General

Profile

Bug #177

Song images for streams

Added by Marius Konitzer about 12 years ago. Updated about 12 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
core
Target version:
3.4
Start date:
September 22, 2012
Due date:
% Done:

100%

Estimated time:
Affects version:
3.3

Description

I am the developer of Audacious-DVB, an Audacious plugin that plays audio streams from a DVB adapter.

Since version 3.2 Audacious prevents plugins using non-'file://' URLs (e.g. Audacious-DVB uses 'dvb://') from providing their own song images (see art_item_new in src/audacious/art.c).
This is kind of a regression, because it was possible for non-'(http|https|mms)://' URLs before (see audgui_pixbuf_for_entry in src/libaudgui/util.c).
The change was introduced by commit commit:57faea2041987fd2e1c46753414c649bc8b0cb42.

Is there any way to restore the old functionality, i.e. let the respective plugin decide whether to provide a song image or not?

History

#1 Updated by John Lindgren about 12 years ago

  • Status changed from New to Closed
  • Target version set to 3.4
  • % Done changed from 0 to 100
  • Affects version deleted (3.2, 3.2.1, 3.2.2, 3.2.3, 3.3-alpha1, 3.2.4, 3.3-beta1, 3.3-beta2, 3.4, 3.3.1, 3.3.2)

You're probably right that blacklisting anything but file:// is too drastic. I've removed the check in the 3.4.x branch:
https://github.com/audacious-media-player/audacious/commit/3181d74ad7dae2205b05d30d08de5a148d63327a

Also available in: Atom PDF