Bug #243

AOSD plug-in out-of-bounds array access with old Audacious config values

Added by Michael Schwendt about 1 year ago. Updated about 1 year ago.

Status:Closed Start date:January 22, 2013
Priority:Minor Due date:
Assignee:- % Done:

100%

Category:plugins/aosd
Target version:3.3.4
Affects version:3.3.3

Description

https://bugzilla.redhat.com/show_bug.cgi?id=902796#c2

The AOSD plug-in trigger config constants have changed between Audacious 3.2.4 and 3.3. One trigger constant has been removed, the other ones have been lowered by one. That causes several parts of the AOSD plug-in to crash due to array out-of-bounds access.

The attached patch can avoid the crash, but since the trigger constants have changed, it cannot be guaranteed that Audacious 3.3.3 actives the same triggers as 3.2.4.

It might have been better to rename the "trigger_active" config value in Audacious 3.3, even if that would break a compatible AOSD config for a few users.

audacious-plugins-3.3.3-aosd-trigger-config.patch Magnifier - brute-force work-around (677 Bytes) Michael Schwendt, January 22, 2013 15:21

Associated revisions

Revision b02a0933
Added by John Lindgren about 1 year ago

aosd: Don't crash on invalid trigger values. Closes: #243.

Revision a3c4df32
Added by John Lindgren about 1 year ago

aosd: Don't crash on invalid trigger values. Closes: #243.

History

#1 Updated by John Lindgren about 1 year ago

  • % Done changed from 0 to 100
  • Target version set to 3.3.4
  • Status changed from New to Closed
  • Category set to plugins/aosd

Also available in: Atom PDF