Bug #243: AOSD plug-in out-of-bounds array access with old Audacious config values - Audacious - Redmine

Bug #243

AOSD plug-in out-of-bounds array access with old Audacious config values

Added by Michael Schwendt 4 months ago. Updated 4 months ago.

Status:

Closed

Start date:

January 22, 2013

Priority:

Minor

Due date:

Assignee:

% Done:

100%

Category:

plugins/aosd

Target version:

3.3.4

Affects version:

3.3.3

Description

https://bugzilla.redhat.com/show_bug.cgi?id=902796#c2

The AOSD plug-in trigger config constants have changed between Audacious 3.2.4 and 3.3. One trigger constant has been removed, the other ones have been lowered by one. That causes several parts of the AOSD plug-in to crash due to array out-of-bounds access.

The attached patch can avoid the crash, but since the trigger constants have changed, it cannot be guaranteed that Audacious 3.3.3 actives the same triggers as 3.2.4.

It might have been better to rename the "trigger_active" config value in Audacious 3.3, even if that would break a compatible AOSD config for a few users.

audacious-plugins-3.3.3-aosd-trigger-config.patch - brute-force work-around (677 Bytes) Michael Schwendt, January 22, 2013 15:21