[PATCH] libaudtag: Verify tag length info against decoder length
|Status:||Closed||Start date:||May 01, 2014|
|Assignee:||William Pitcock||% Done:||
Some mp3 files have wrong TLEN tags, one example is:
Which has an extremely wrong TLEN tag, but I've also seen mp3 files where
TLEN is set the album length instead of the track length.
To stop audacious from showing a completely wrong length in these cases add
some FIELD_LENGTH sanity checks. This fixes both issues for me.
#1 Updated by John Lindgren over 2 years ago
- Tracker changed from Bug to Feature
- Category set to libaudtag
- Affects version 3.5 added
#2 Updated by John Lindgren over 2 years ago
#440 fixed some types of invalid TLEN fields. Also, the link in the issue description is now dead.
#3 Updated by Hans de Goede over 2 years ago
#440 is not relevant in this case, in both my examples the mp3 files contain a purely integer TLEN field, it is just that the content is bogus.
About the broken link, that is my bad I copy pasted from a terminal and only copy and pasted the first 80 chars, here is the proper link:
As you can see this has a TLEN field with a value which is an integer, but other then that is utter non sense. Note the other troublesome files which I have which I cannot share have a more sane TLEN, it contains the length of the entire album instead of the individual songs, so still wrong :|
The attached patch fixes both.
#4 Updated by William Pitcock about 2 years ago
- Status changed from New to Resolved
- Assignee set to William Pitcock
- Target version set to 3.6
- % Done changed from 0 to 100
I merged a modified version of this patch (due to C++ conversion) to 3.6 just now.