Bug #577

32-bit Bit-Depth produces distorted sound (pops/crackles/etc)

Added by Evgen Whatever about 2 years ago. Updated about 2 years ago.

Status:Closed Start date:October 13, 2015
Priority:Major Due date:
Assignee:- % Done:

100%

Category:core
Target version:3.7
Affects version:3.7-beta1

Description

As title says. First noticed in v3.7 beta 1. Previous version 3.6.2 was fine. Other formats/bit-depth are fine too.
That's not hardware-related because generated with File Writer file has exactly the same problem. Samples attached.

sample.mp3 (165.6 kB) Evgen Whatever, October 13, 2015 14:24

proper_v3-6.mp3 (164.2 kB) Evgen Whatever, October 13, 2015 14:24

broken_v3-7b1.mp3 (164.2 kB) Evgen Whatever, October 13, 2015 14:24

Associated revisions

Revision d5ed3425
Added by John Lindgren about 2 years ago

Fix overflow in 32-bit integer conversion. Closes: #577.

0x7fffffff cannot be represented in a 32-bit float and is rounded up to
2^31, which overflows a 32-bit integer. Audacious 3.6 and older were
saved by the use of 64-bit floats in the conversion, which was, however,
inefficient. Fix the problem a different way by limiting the 32-bit
float data to 0x7fffff80 before conversion.

History

#1 Updated by John Lindgren about 2 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed
  • Category set to core
  • Affects version 3.7-beta1 added

Fixed.

Also available in: Atom PDF