Feature #621

Drag & Drop from Search tool into playlists

Added by Ali Baba about 1 year ago. Updated 8 months ago.

Status:Closed Start date:February 12, 2016
Priority:Minor Due date:
Assignee:- % Done:

100%

Category:plugins/search tool
Target version:3.8
Affects version:3.7.1

Description

I would like to drag & drop into playlists from search tool. It works from folders, other playslists, file managers but not with the audacious search tool.

search-tool-dnd.patch Magnifier (1.8 kB) Paul Franke, August 13, 2016 11:33

fix-dnd.patch Magnifier (1.3 kB) Paul Franke, August 14, 2016 02:37

fix-dnd-really.patch Magnifier (2.9 kB) Paul Franke, August 14, 2016 15:40

Associated revisions

Revision 27f48853
Added by John Lindgren 8 months ago

search-tool: Support drag and drop to playlists. Closes: #621.
Based on a patch by Paul Franke.

History

#1 Updated by Jim Turner 10 months ago

I actually used the Search tool for the 1st time the other day and I SECOND this request!

#2 Updated by John Lindgren 9 months ago

Yes, this would make sense. A patch would be welcome.

#3 Updated by Paul Franke 8 months ago

I hope it is ok to post a patch this way.

#4 Updated by John Lindgren 8 months ago

  • Status changed from New to Closed
  • Target version set to 3.8
  • % Done changed from 0 to 100

Merged, thank you!

#5 Updated by Paul Franke 8 months ago

Great, thank you. Unfortunately the patch supporting lists that are only a drag source prevents dragging more than one selected search-tool result to a playlist. Fix attached.

#6 Updated by John Lindgren 8 months ago

That's rather odd ... anyway, thanks for the fix, applied.

#7 Updated by Paul Franke 8 months ago

This took me some time tracking down, but my last fix is rubbish.

Multiple selections of lists that are only a drag source get mistakenly cleared by button_release_cb because of model->frozen = true. model->frozen is set false by drag_motion. But the drag-motion signal seems to be fired for destinations only. A quick search on gtk drag-and-drop signal order revealed chapter three of http://www.compsci.hunter.cuny.edu/~sweiss/course_materials/csci493.70/lecture_notes/GTK_dragndrop.pdf.

Fix attached.

#8 Updated by John Lindgren 8 months ago

Excellent find, thanks. I looked briefly at the logic last night trying to figure out what was really going on, but this code is very subtle; evidently even its author has trouble understanding it any more. :(

#9 Updated by Paul Franke 8 months ago

Thank you very much merging that all so fast.

Also available in: Atom PDF