Drag & Drop from Search tool into playlists
|Status:||Closed||Start date:||February 12, 2016|
I would like to drag & drop into playlists from search tool. It works from folders, other playslists, file managers but not with the audacious search tool.
#1 Updated by Jim Turner 10 months ago
I actually used the Search tool for the 1st time the other day and I SECOND this request!
#3 Updated by Paul Franke 8 months ago
- File search-tool-dnd.patch added
I hope it is ok to post a patch this way.
#4 Updated by John Lindgren 8 months ago
- Status changed from New to Closed
- Target version set to 3.8
- % Done changed from 0 to 100
Merged, thank you!
#5 Updated by Paul Franke 8 months ago
- File fix-dnd.patch added
Great, thank you. Unfortunately the patch supporting lists that are only a drag source prevents dragging more than one selected search-tool result to a playlist. Fix attached.
#7 Updated by Paul Franke 8 months ago
- File fix-dnd-really.patch added
This took me some time tracking down, but my last fix is rubbish.
Multiple selections of lists that are only a drag source get mistakenly cleared by button_release_cb because of model->frozen = true. model->frozen is set false by drag_motion. But the drag-motion signal seems to be fired for destinations only. A quick search on gtk drag-and-drop signal order revealed chapter three of http://www.compsci.hunter.cuny.edu/~sweiss/course_materials/csci493.70/lecture_notes/GTK_dragndrop.pdf.
#8 Updated by John Lindgren 8 months ago
Excellent find, thanks. I looked briefly at the logic last night trying to figure out what was really going on, but this code is very subtle; evidently even its author has trouble understanding it any more. :(