Bug #623

GCC 6 fix for JACK plugin

Added by Michael Schwendt almost 2 years ago. Updated over 1 year ago.

Status:Closed Start date:February 14, 2016
Priority:Minor Due date:
Assignee:- % Done:

100%

Category:plugins/jack
Target version:3.7.2
Affects version:3.7.1

Description

jack-ng.cc needs to include <iterator> for GCC 6 compilation:

if g++ -fPIC -DPIC -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -std=c++0x -std=gnu++11 -ffast-math -Wall -pipe -Wno-deprecated-declarations -Wtype-limits -Woverloaded-virtual -fvisibility=hidden -include config.h   -I../.. -c -o jack-ng.plugin.o jack-ng.cc; then \
    printf "Successfully compiled jack-ng.cc (plugin).\n"; \
else \
    err=$?; printf "Failed to compile jack-ng.cc (plugin)!\n"; exit $err; \
fi
jack-ng.cc: In member function 'virtual void JACKOutput::close_audio()':
jack-ng.cc:259:42: error: no matching function for call to 'end(jack_port_t* [10])'
     std::fill (m_ports, std::end (m_ports), nullptr);
                                          ^
In file included from /usr/include/libaudcore/audstrings.h:26:0,
                 from jack-ng.cc:22:
/usr/include/c++/6.0.0/initializer_list:99:5: note: candidate: template<class _Tp> constexpr const _Tp* std::end(std::initializer_list<_Tp>)
     end(initializer_list<_Tp> __ils) noexcept
     ^~~
/usr/include/c++/6.0.0/initializer_list:99:5: note:   template argument deduction/substitution failed:
jack-ng.cc:259:42: note:   mismatched types 'std::initializer_list<_Tp>' and 'jack_port_t** {aka _jack_port**}'
     std::fill (m_ports, std::end (m_ports), nullptr);
                                          ^

Associated revisions

Revision bd64a4ea
Added by John Lindgren over 1 year ago

jack-ng: Add missing #include. Closes: #623.

Revision 4a0da0b9
Added by John Lindgren over 1 year ago

jack-ng: Add missing #include. Closes: #623.

History

#1 Updated by John Lindgren over 1 year ago

  • % Done changed from 0 to 100
  • Target version set to 3.7.2
  • Status changed from New to Closed

Also available in: Atom PDF