Bug #628

Error dialog popup during playback on Windows

Added by Bruce Olney 12 months ago. Updated 10 months ago.

Status:Closed Start date:March 12, 2016
Priority:Major Due date:
Assignee:- % Done:

100%

Category:plugins/mpg123
Target version:3.7.3
Affects version:3.7, 3.7.1

Description

See attached screen Capture.PNG.

These occur when changing songs. But not on every song. Playback continues uninterrupted.

The popup interrupts whatever application has focus. Close the pop-up and focus returns to interrupted application.

I'm not completely sure, but they seem to happen less often on version 3.7.1. They happened more often on version 3.7.

Thanks!

Capture.PNG (7.6 kB) Bruce Olney, March 12, 2016 00:39

16. Night Sky.mp3 - Playing this file causes the popup error dialog. (4.2 MB) Bruce Olney, March 14, 2016 18:49

Associated revisions

Revision 59ab0aa9
Added by John Lindgren 10 months ago

mpg123: Silence nuisance resync errors. Closes: #628.

Revision 50749764
Added by John Lindgren 10 months ago

mpg123: Silence nuisance resync errors. Closes: #628.

History

#1 Updated by Bruce Olney 12 months ago

Note: The message pops up when switching to a new song. The file indicated in the dialog is the song that has just finished playing.

#2 Updated by Bruce Olney 12 months ago

I've also noticed that it is specific files that cause the message. Every time these files play, the pop-up message is displayed.

Would it be useful to send you one of the files?

#3 Updated by John Lindgren 12 months ago

Yes, please, if you could attach one of the files, that would be most helpful.

#4 Updated by Bruce Olney 12 months ago

Playing the attached file causes the popup error dialog.

Let it play all the way through. The error dialog is displayed just as audacious starts the next track.

I note that in listening to this track there is a lot of silence at the end. Could the length be incorrect?

Thanks!

#5 Updated by John Lindgren 12 months ago

mpg123 and mp3check both agree that there is junk at the end of the file (starting at byte offset 4,402,739). It looks like it's part of an ID3 tag that some crappy tag editor left there when saving the file.

If you had looked at the console output (unfortunately, it's difficult to see it in Windows; you have to redirect it to a file), you would have seen something like this:

ERROR mpg123.cc:285 [print_mpg123_error]: mpg123 error in file:///.../16.%20Night%20Sky.mp3: Failed to find valid MPEG data within limit on resync. (code 28)

In a future version, we should look into making the error message in the GUI more useful.

#6 Updated by Bruce Olney 11 months ago

These files play on every other media player I have tried with no problems, errors or warnings. I probably ripped them myself a long time ago. I have no idea what codec or software was used.

I have hundreds of these files. I would prefer that no errors are indicated to the user.

#7 Updated by John Lindgren 11 months ago

  • Status changed from New to Rejected

#8 Updated by Bruce Olney 11 months ago

That's too bad. This makes Audacious pretty much unusable for me.

#9 Updated by xyz dragon 10 months ago

I also have some of these bad files and I agree, this warning is pretty obtrusive. Why not deactivate the dialog from appearing? Isn't a log message to the console enough, if it doesn't hinder playing?

#10 Updated by xyz dragon 10 months ago

xyz dragon wrote:

I also have some of these bad files and I agree, this warning is pretty obtrusive. Why not deactivate the dialog from appearing? Isn't a log message to the console enough, if it doesn't hinder playing?

E.g. by introducing some kind of option or just commenting out lines 364-367 in audacious/src/libaudcore/playback.cc in the latest git commit, i.e. 4558f917754dad51c04

        //aud_ui_show_error (str_printf (_("Error playing %s:\n%s"),
        // (const char *) pb_info.filename, pb_info.error_s ?
        // (const char *) pb_info.error_s : _("Unknown playback error " 
        // "(check the console for detailed error information)")));

#11 Updated by John Lindgren 10 months ago

  • Category set to plugins/mpg123
  • Status changed from Rejected to Closed
  • Target version set to 3.7.3
  • % Done changed from 0 to 100

Pragmatically, it seems there are enough broken MP3s out there that we should silence this particular error. Fixed.

Also available in: Atom PDF