Feature #731

Please support directories in .m3u files

Added by Cristian Rigamonti about 1 month ago. Updated 29 days ago.

Status:Closed Start date:July 12, 2017
Priority:Minor Due date:
Assignee:- % Done:

100%

Category:libaudcore
Target version:3.9
Affects version:3.7.2

Description

Audacious currently doesn't handle directories in .m3u files, giving the error:

File format not recognized

Expected behaviour: audacious should play the files contained in the directory, as it currently happens when running

audacious directory

Associated revisions

Revision 2f91fa7e
Added by John Lindgren about 1 month ago

Support adding folder paths within playlists. Closes: #731.

History

#1 Updated by Jim Turner about 1 month ago

Absolute (full) or relative directories or both? Windows or Linux/Unix? Can you provide example?

#2 Updated by Cristian Rigamonti about 1 month ago

Absolute (full) or relative directories or both? Windows or Linux/Unix? Can you provide example?

Audacios 3.7.2 on Linux. I've tried both absolute and relative paths, none works.

Example: just put the name of a directory that contains media files in a test.m3u file, then run audacious test.m3u

#3 Updated by Cristian Rigamonti about 1 month ago

FYI, besides the error popup that I described in my first message, I also get a stream of error messages like this in the xterm

ERROR vfs_local.cc:162 [fread]: (PATH CONTAINED IN THE M3U FILE): Is a directory

#4 Updated by Jim Turner about 1 month ago

Thanks for clarifying. I checked and indeed, it doesn't work. It doesn't look like it's part of the basic m3u format, but the wiki indicates that it's an "extended" feature. The m3u plugin code looks similar to that of audacious/main.cc which can load a list of entries from the command line (which DOES handle directories), so it seems like it should work but doesn't. I'll look into it myself, but for now, you'll pbly have to wait and see what, if anything, John wants to do a/b it as I not part of the Audacious team myself, but have contributed patches and have worked a bit with that particular (m3u plugin) code before. What's your email?

Regards,

Jim

#5 Updated by John Lindgren about 1 month ago

  • Description updated (diff)
  • Category set to libaudcore
  • Status changed from New to Closed
  • Target version set to 3.9
  • % Done changed from 0 to 100

Jim, the m3u plugin is very simple and doesn't know (nor need to know) anything about folders. The relevant code is in libaudcore/adder.cc.

This is actually trivial to implement; in fact, a net removal of code. My concern was that it could lead to infinite recursion (think of an .m3u file containing the single relative path "."), but actually we wouldn't try to add the .m3u file again in that case, so we're okay.

#6 Updated by Jim Turner 29 days ago

Thanks John for the quick fix on this - savin' me some research / work! I didn't know nor care a/b the issue until someone complained, and it looked like it was a pretty logical and pbly. somewhat easy feature to implement / contribute. I tried it out & it seems to work fine here!

I'm assuming the OP's not looking for some wildcard stuff like: "/path/*.mp3", etc. as that does NOT work (wildcard chars are translated to stuff like %21, etc. whereas the command line wildcards do work, I presume b/c they are expanded by the shell). Besides, that's not even in the "extended m3u" spec.

Also available in: Atom PDF