Audacious - OLD, PLEASE USE GITHUB DISCUSSIONS/ISSUES

Hi,

This has been a long-time project of mine. Finally I had the time to implement it and well, it's (almost) done now. :-)
You can get it at https://github.com/Pitxyoki/audacious-plugins/. The source for the plugin itself is at src/scrobbler2.

• The plugin uses version 2.0 of the scrobbling API, which means no more username/password stored in plaintext on the config file (a revokable session key is stored instead).
• Man-in-the-middle/impersonation attacks are a bit more difficult now, though unfortunately this API still has some security flaws. I think we're better with this than we were with the previous version anyway.
• Configuration is now easier too. You only have to click a button, go to your last.fm profile, give permission to Audacious and tell it to re-check permissions.

I've been using it myself since the last weeks without issues.

Some relevant things to be done before getting it pulled to Audacious:

1. I'm not sure if the configuration window is easy to understand. I did it with a single button (see attachments for the complete flow) - it is simple, but I'm not sure if it isn't excessively simple now. What do you think?
2. I saw on other plugins that functions like vfs_fopen, vfs_fclose, etc, from libaudcore/vfs.h are used for file manipulation. Should I be using that for handling the scrobble.log instead of the native fopen/fclose? The scrobble.log is a file on the user's config folder and is only written when a new track is ready to be scrobbled and after a track has been scrobbled, like the old scrobblequeue.txt.
3. I'm not sure where and how to put licensing information. Should each source file mention it? I don't mind the license to be GPLv3 and I'd like to keep a mention on the plugin's source files that I am the initial author. Is there a "standard" way of doing this for Audacious' plugins? Each plugin seems to do it on its own way.
4. I did not test playing Internet streams. There is probably a regression to the current plugin on this.

There are other minor features remaining to be implemented. You can see them on github: https://github.com/Pitxyoki/audacious-plugins/issues/.

With that said, I'd like to know what you think of the current state of the plugin. Is there anything else you'd like to see improved before pulling it? I'm open to criticism. :)

Best regards,
Luís Picciochi