Audacious - OLD, PLEASE USE GITHUB DISCUSSIONS/ISSUES

It would be more helpful if you posted steps to reproduce the problem instead of a huge patch with no explanation of what it does.

for playing music do loop { write_audio(); period_wait(); }

old code:
period_wait = poll 2 descriptors #1 pipe descriptor #2 /dev/pcm descriptor (all descriptors in nonblock mode),
on normal play = all ok, but on pause poll not wait descriptor #2 always ready for write (infinite loop).

new code:
period_wait check if paused when wait pthread_cond_wait(), and /dev/pcm descriptor in block mode (poll not need).
pipe not need it replace pthread condition.

Blocking mode is not an option since write_audio() needs to return immediately. So your patch will not be accepted as-is. Please post steps to reproduce the problem, so that we can work towards a viable solution.

John Lindgren wrote:

Blocking mode is not an option since write_audio() needs to return immediately. So your patch will not be accepted as-is.

In what situations write_audio() needs to return immediately?

Please post steps to reproduce the problem, so that we can work towards a viable solution.

Pause playing music and problem reproduce.

fd in nonblock mode

poll(fd);
write(fd);

==

fd in block mode
write(fd)

The new patch still breaks drain() because you removed poll_wake(). Read the documentation and stop making changes without understanding what was there before.

Dmitry Vagin wrote:

In what situations write_audio() needs to return immediately?

Always.

John Lindgren wrote:

The new patch still breaks drain() because you removed poll_wake(). Read the documentation and stop making changes without understanding what was there before.

which documentation to read?

Look at libaudcore/plugin.h for starters.