Project

General

Profile

Bug #777

fix crashes when pthread_create fails

Added by Zhouyang Jia about 7 years ago. Updated about 7 years ago.

Status:
Rejected
Priority:
Major
Assignee:
-
Category:
-
Target version:
-
Start date:
February 27, 2018
Due date:
% Done:

0%

Estimated time:
Affects version:
3.9

Description

The library function "pthread_create" may fail. When it happens, Audacious will crash.

I think it's unsafe to assume the library function would be correct. It would be better if we could handle the error properly (at least printing a log message).

Attached please find the patch against version 3.9. Hopefully, it can solve these potential bugs.

audacious-plugins-3.9.patch (1.86 KB) audacious-plugins-3.9.patch Add error handling of pthread_create in audacious-plugins Zhouyang Jia, February 27, 2018 08:47
audacious-3.9.patch (3.1 KB) audacious-3.9.patch Add error handling of pthread_create in audacious Zhouyang Jia, February 27, 2018 08:47

History

#1 Updated by John Lindgren about 7 years ago

Are you seeing an actual crash, or is this just theoretical?

#2 Updated by Zhouyang Jia about 7 years ago

It's just theoretical.

#3 Updated by John Lindgren about 7 years ago

  • Status changed from New to Rejected

In that case, I'm closing this. Being robust against memory allocation and thread creation failures would be nice, but it adds complexity, and anyway, there are other higher priorities currently.

Also available in: Atom PDF