Project

General

Profile

Bug #951

Handle Window manager exit corretly

Added by Tom Tarson over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/qtui
Target version:
4.0.1
Start date:
April 05, 2020
Due date:
% Done:

0%

Estimated time:
Affects version:
4.0

Description

When the windowmanger exits in KDE for example, QT emits this signal commitDataRequest

https://doc.qt.io/qt-5/qguiapplication.html#commitDataRequest

and tells the application to save it's current state and then calls the eventClose method.

This signal isn't handled in Audacious and if KDE exits, it blocks the logout as it always ignores the event in the eventClose method.

Accepting the event always in the eventClose method, doesn't block the KDE logout anymore but it would maybe be a better idea to check if
commitDataRequest was emitted before the eventClose method is called.

The patch attached will just always accept the event.

kde_exit.patch (356 Bytes) kde_exit.patch Tom Tarson, April 05, 2020 15:45

History

#1 Updated by Ariadne Conill over 4 years ago

  • Target version set to 4.0.1
  • Status changed from New to Closed

I committed an adjusted version of this patch that should match the GTK version's behaviour. It will be in 4.0.1.

Also available in: Atom PDF