Project

General

Profile

Feature #989

Add keyboard shortcut for "Add Folder" in QT UI

Added by CJ Kucera about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/qtui
Target version:
Start date:
May 28, 2020
Due date:
% Done:

100%

Estimated time:
Affects version:

Description

Hello! The QT UI has a keyboard shortcut for "Add Files," just like the GTK UI did, but GTK's "Add Files" was able to add directories as well, which was overwhelmingly what I'd use it for. The "Add Folders" menu item in the QT UI doesn't have a shortcut, though, and I'd enjoy having one.

I suppose I'd suggest Ctrl+Shift+F for it, which seems unused currently. I'll attach the patch I'm using to do so on my system, at the moment.

Thx!

apoc_add_folder_shortcut.patch (694 Bytes) apoc_add_folder_shortcut.patch Adds Ctrl+Shift+F to Add Folder CJ Kucera, May 28, 2020 15:53

History

#1 Updated by John Lindgren about 1 month ago

I'm hesitating about Ctrl+Shift+F, mainly because of the connection with Ctrl+F = Find.

The existing shortcuts are:

Ctrl[+Shift]+O = Open[Add] Files
Ctrl[+Shift]+L = Open[Add] URL

To continue with that pattern, what about:

Ctrl[+Shift]+K = Open[Add] Folder

I realize "K" isn't intuitively associated with "Folder", but it's currently unused and near O+L in the QWERTY layout.

#2 Updated by CJ Kucera about 1 month ago

Oh, for sure! I'd meant to mention that I didn't actually care what the shortcut was. I'm perfectly happy with Ctrl+Shift+K. :)

#3 Updated by John Lindgren about 1 month ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

Cool, I went ahead with Ctrl[+Shift]+K:
https://github.com/audacious-media-player/audacious-plugins/commit/7078570e882d7b3d4182a0cc57b1d0a347e53ff8

I'll probably release 4.0.4 in the next few days, including this addition.

#4 Updated by CJ Kucera about 1 month ago

Awesome, thanks a bunch!

#5 Updated by John Lindgren about 1 month ago

  • Target version set to 4.0.4

Also available in: Atom PDF