Project

General

Profile

Bug #218

"Close Playlist" dialog ignores GTK dialog button order

Added by Stephan Sokolow over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
libaudgui
Target version:
-
Start date:
November 26, 2012
Due date:
% Done:

0%

Estimated time:
Affects version:
3.3.2

Description

When gtk-alternative-button-order=0, GTK+ applications are supposed to put the OK/Yes/Confirm button to the right of the Cancel/No button. (GNOME/MacOS order)

However, contrary to every other application on my desktop (including Qt applications via GtkStyle), Audacious's "Close Playlist" dialog uses KDE/Windows button order and puts "Yes" to the left of "No".

snapshot1.png (19.8 KB) snapshot1.png Affected dialog Stephan Sokolow, November 26, 2012 06:11
snapshot2.png (10.8 KB) snapshot2.png Other GTK+ dialog on the same desktop for comparison Stephan Sokolow, November 26, 2012 06:11
snapshot3.png (18.8 KB) snapshot3.png Qt dialog on the same desktop for comparison Stephan Sokolow, November 26, 2012 06:11
confirm.patch (4.42 KB) confirm.patch Thomas Lange, November 26, 2012 16:51

History

#1 Updated by Thomas Lange over 11 years ago

Thanks for your bug report Stephan.

The bug is caused by using a GtkWindow with custom content instead of a GtkMessageDialog.
Attached is a patch which fixes this. John, please review.

Should I use a gpointer parameter in "confirm_delete_cb()"?

#2 Updated by John Lindgren over 11 years ago

Looks good. Personally I prefer (void *) instead of gpointer, int instead of gint, etc.

#4 Updated by Thomas Lange over 11 years ago

  • Status changed from New to Resolved

#5 Updated by Thomas Lange over 11 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF