Bug #218
"Close Playlist" dialog ignores GTK dialog button order
| Status: | Closed | Start date: | November 26, 2012 | |
|---|---|---|---|---|
| Priority: | Minor | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | libaudgui | |||
| Target version: | - | |||
| Affects version: | 3.3.2 |
Description
When gtk-alternative-button-order=0, GTK+ applications are supposed to put the OK/Yes/Confirm button to the right of the Cancel/No button. (GNOME/MacOS order)
However, contrary to every other application on my desktop (including Qt applications via GtkStyle), Audacious's "Close Playlist" dialog uses KDE/Windows button order and puts "Yes" to the left of "No".
snapshot1.png - Affected dialog (19.8 kB)
snapshot2.png - Other GTK+ dialog on the same desktop for comparison (10.8 kB)
snapshot3.png - Qt dialog on the same desktop for comparison (18.8 kB)
confirm.patch
(4.4 kB)
Associated revisions
libaudgui: Respect 'gtk-alternative-button-order' setting. Fixes #218
libaudgui: Respect 'gtk-alternative-button-order' setting. Fixes #218
History
#1
Updated by Thomas Lange 6 months ago
- File confirm.patch added
- Category changed from plugins/gtkui to libaudgui
Thanks for your bug report Stephan.
The bug is caused by using a GtkWindow with custom content instead of a GtkMessageDialog.
Attached is a patch which fixes this. John, please review.
Should I use a gpointer parameter in "confirm_delete_cb()"?
#2
Updated by John Lindgren 6 months ago
Looks good. Personally I prefer (void *) instead of gpointer, int instead of gint, etc.
#3
Updated by Thomas Lange 6 months ago
#4
Updated by Thomas Lange 6 months ago
- Status changed from New to Resolved
#5
Updated by Thomas Lange 6 months ago
- Status changed from Resolved to Closed