Bug #458

build fails if faad headers are missing

Added by Götz Waschk over 2 years ago. Updated over 2 years ago.

Status:Closed Start date:August 06, 2014
Priority:Minor Due date:
Assignee:- % Done:

100%

Category:plugins/aac
Target version:3.5.2
Affects version:3.5.1

Description

This is a regression in audacious-plugins 3.5.1 caused by commit e6aceb23563a416615fad2812fe0f5a9c7501a3d: If aac is not explicitly disabled and the faad headers are not installed, the build will fail like this:
libmp4.c:8:22: fatal error: neaacdec.h: No such file or directory

configure should fail instead if aac is not disabled and faad headers are missing, that would be nicer.

build.0.20140806084404.log - build log audacious 3.5.1 without faad installed (41.8 kB) Götz Waschk, August 09, 2014 13:02

Associated revisions

Revision d25c8a85
Added by John Lindgren over 2 years ago

Check for neaacdec.h instead of faad.h. Closes: #458.

Revision e57387cf
Added by John Lindgren over 2 years ago

Check for neaacdec.h instead of faad.h. Closes: #458.

History

#1 Updated by John Lindgren over 2 years ago

  • Status changed from New to Closed
  • Target version set to 3.5.2
  • % Done changed from 0 to 100

I suppose we ought to check for neaacdec.h instead of faad.h (the old name). Still I'm confused how you managed to install faad.h but not neaacdec.h.

#2 Updated by Götz Waschk over 2 years ago

John Lindgren wrote:

I suppose we ought to check for neaacdec.h instead of faad.h (the old name). Still I'm confused how you managed to install faad.h but not neaacdec.h.

I did not. The check for faad failed, but the aac plugin is not disabled in that case. Please see the attached log file of the build.

#3 Updated by John Lindgren over 2 years ago

My mistake. It should be really fixed now.

Also available in: Atom PDF