Project

General

Profile

Cover image retrieval via SMB

Added by Jacopo Lorenzetti over 7 years ago

The cover image of local files is both displayed in the player and accessible via MPRIS 2.

I experimented a bit with cover image retrieval from an SMB share accessed via GVFS and I found out that if I access the files from the ~/.gvfs path, then the cover image is correctly displayed in the player but is not available via MPRIS 2. If I access the same files from the smb:// URI via the GIO transport, then the cover image is neither displayed in the player nor available via MPRIS 2.

Should I file one or more bugs/feature requests?

Tell me if you need me to make further tests.


Replies (4)

RE: Cover image retrieval via SMB - Added by John Lindgren over 7 years ago

Currently cover images are only enabled for file:// URI's because trying to read them across a network can be quite slow. If you want to play around with loading images over SMB then just change the test "if (strncmp (file, "file://", 7))" in src/audacious/art.c.

RE: Cover image retrieval via SMB - Added by Jacopo Lorenzetti over 7 years ago

Ok, thank you. I understand the problem. I'm thinking that it could be nice to add a control in the cover image retrieval preferences to ask the user if they want to retrieve the cover image always or for local files only (and maybe another control for specifying to retrieve it only for files smaller than a given size). Not so important but I think it would be elegant.

I noticed that the mpris2 plugin successfully provides the cover image for local files but for some reason fails to do the same for the files in the ~/.gvfs path (even if they are accessed with a file:// URI and the cover is correctly fetched and displayed in the info bar). does this happen by design or something isn't working properly?

RE: Cover image retrieval via SMB - Added by John Lindgren over 7 years ago

Jacopo Lorenzetti wrote:

I noticed that the mpris2 plugin successfully provides the cover image for local files but for some reason fails to do the same for the files in the ~/.gvfs path (even if they are accessed with a file:// URI and the cover is correctly fetched and displayed in the info bar). does this happen by design or something isn't working properly?

Something isn't working properly. If the cover art is shown in the info bar it should be available for MPRIS2 as well. I suggest using D-Feet to check whether mpris:artUrl is there and points to a valid image file.

RE: Cover image retrieval via SMB - Added by Jacopo Lorenzetti over 7 years ago

Yes, mpris:artUrl is there and points to the right image file. If I understand, this means that everything is ok on the Audacious part and maybe there's some strange problem (shouldn't a FUSE resource appear just like every other local file?) on the mpris client part.

    (1-4/4)