Project

General

Profile

Bug #1052

Autoreconf no longer working with autoconf 2.70

Added by Thomas Lange almost 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
-
Target version:
4.1
Start date:
January 10, 2021
Due date:
% Done:

100%

Estimated time:
Affects version:

Description

When using autoconf 2.70, the command autoreconf and therefore our mkrelease.sh script no longer work.
With older versions the error was only a warning.

$ autoreconf -I m4
configure.ac: error: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION

Please see the attached patch.
See also: https://github.com/GNOME/libgsf/commit/91027d3447666c6f13c31b4b5984e1a8212983da

gettext.patch (389 Bytes) gettext.patch Thomas Lange, January 10, 2021 01:11

History

#1 Updated by Thomas Lange almost 4 years ago

@John: Do we support systems where gettext is older than 0.19.6 (released in 2015)?

#2 Updated by John Lindgren almost 4 years ago

Years ago, we used to just run ./autogen.sh rather than autoreconf. Would that solve the problem?

#3 Updated by Thomas Lange almost 4 years ago

Yes, autogen.sh still works, see also: https://aur.archlinux.org/cgit/aur.git/commit/?h=audacious-git&id=5fac5860bd5717d7a968241118dd8c488cf5fb35
But relying on this script is just a workaround. Why not fixing it properly? :)

#4 Updated by John Lindgren almost 4 years ago

Okay, if we want to add the version requirement, then I would suggest: AM_GNU_GETTEXT_VERSION(0.18.1)

This works on the oldest and newest system that I have tested on.

#5 Updated by John Lindgren almost 4 years ago

It looks to me as though adding AM_GNU_GETTEXT_REQUIRE_VERSION is only necessary/beneficial for projects using autopoint (we are not). Correct me if I am wrong.

#6 Updated by Thomas Lange almost 4 years ago

All right, AM_GNU_GETTEXT_VERSION(0.18.1) alone works here too on Arch Linux. Thanks John.

#7 Updated by John Lindgren almost 4 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed

Thanks for confirming. I went ahead and pushed the fix.

Also available in: Atom PDF