16MB limit opening m3u files
File -> Open Files -> [Navigate to Directory] -> Choose large.m3u file
Playlist truncated after about 16MB (after about 110000 entries with this playlist)
Remove comment lines using grep -v '^#'from large.m3u and playlist loads completely (currently 113224 entries)
This 16MB limit seems arbitrary, I would just expect audacious to continue to read m3u playlist until the end of file.
Audacious Version and OS level:
[root@music ~]# audacious -v
Audacious 4.1 (Fedora package)
[root@music ~]# uname -a
Linux music.purcell.lan 5.19.13-100.fc35.x86_64 #1 SMP PREEMPT_DYNAMIC Tue Oct 4 16:05:25 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
#1 Updated by Thomas Lange about 2 months ago
The buffer size in VFSFile::read_all() is indeed limited to 16 MiB.
@John: Do you think we should increase it? Or can the m3u plugin use another approach to load the file?
#2 Updated by John Lindgren about 2 months ago
I suppose the easy fix would be to increase the limit. It is there simply to prevent a malicious (possibly remote) file from exhausting memory, but I don't think there is anything magical about the 16 MiB number. We could probably raise it to 256 MiB easily and still be fine as far as OOM scenarios.
#3 Updated by Thomas Lange about 2 months ago
- Target version set to 4.2.1
- Category set to libaudcore
Thanks for reporting.