Project

General

Profile

Bug #136

modplug plugin includes sys/mman.h but it doesn't seem to need it.

Added by Carlo Bramini over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/modplug
Target version:
3.2.4
Start date:
June 23, 2012
Due date:
% Done:

100%

Estimated time:
Affects version:
3.2.3

Description

The file:

src/modplug/archive/arch_raw.cxx

includes sys/mman.h but it does not seem to be required.
Instead, it looks like that there are not sources using mmap() and unmap() stuff and this file is the only one that it includes it.
Actually, the inclusion of this file breaks the compilation of the plugin: if it is not required by some platform or for some reason, it would be better to remove it or at least make it conditional.

On previous version, I was able to make it working by simply removing that line; on newer version in the repository, I do not know what it happens, since I'm still trying to make working GTK+3 on my mingw+msys.

History

#1 Updated by John Lindgren over 12 years ago

  • Category set to plugins/modplug
  • Status changed from New to Closed
  • Target version set to 3.2.4
  • % Done changed from 0 to 100
  • Affects version 3.2.3 added

Fixed.

Also available in: Atom PDF