Project

General

Profile

Bug #146

modplug plugin still fails to compile on Windows.

Added by Carlo Bramini almost 12 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/modplug
Target version:
-
Start date:
July 07, 2012
Due date:
% Done:

100%

Estimated time:
Affects version:
3.2.4

Description

I'm still getting an error when compiling modplug plugin with a not hacked Windows SDK.
The problem is into src/modplug/modplugbmp.cxx, in the implementation of method PlayLoop in ModplugXMMS class: in the processing of the block related to mModProps.mPreamp, there are some variables declared as "uint".
This type does not exists in PSDK and in the official W32API package, so I would like to suggest to change them to "uint32_t", which is the same type used for mBufSize.

Attached patch fixes this behavior.

lst (1.08 KB) lst Fix for this bug Carlo Bramini, July 07, 2012 21:17

History

#1 Updated by John Lindgren almost 12 years ago

  • Category set to plugins/modplug
  • Status changed from New to Closed
  • Target version set to 38
  • % Done changed from 0 to 100
  • Affects version 3.2.4 added
  • Affects version deleted (3.4)

#2 Updated by John Lindgren about 9 years ago

  • Target version deleted (38)

Also available in: Atom PDF