Project

General

Profile

Feature #19

Allow playlist columns to be resized

Added by Artem S. Tashkinov almost 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/gtkui
Target version:
Start date:
December 28, 2011
Due date:
% Done:

100%

Estimated time:
Affects version:

Description

Currently playlist columns cannot be resized.

Also it will be very nice to have a menu item called "Automatically Resize Playlist Columns" so that Auducaious automatically resized columns to match their contents. If the user decides to resize them, then this menu item should get unticked automatically.

aud-resize-columns.diff (605 Bytes) aud-resize-columns.diff John Lindgren, December 16, 2012 21:03
gtkui-resize-columns.diff (9.85 KB) gtkui-resize-columns.diff John Lindgren, December 16, 2012 21:03
gtkui-save-column-widths.diff (7.87 KB) gtkui-save-column-widths.diff John Lindgren, January 14, 2013 02:59

History

#1 Updated by John Lindgren almost 8 years ago

  • Subject changed from Allow to resize playlist columns/Add a menu (checkbox) option to automatically resize columns to Allow to playlist columns to be resized

#2 Updated by John Lindgren almost 8 years ago

  • Subject changed from Allow to playlist columns to be resized to Allow playlist columns to be resized

#3 Updated by John Lindgren almost 8 years ago

  • Category set to plugins/gtkui

#4 Updated by Grant Farnsworth almost 7 years ago

As mentioned in the forum by Netslovdlyasnov Netslovdlyasnov, the addition of the line

gtk_tree_view_column_set_resizable (tree_column, 1);

just before the call to gtk_tree_view_append_column in libaudgui/list.c fixes this issue.

#5 Updated by John Lindgren almost 7 years ago

1) Automatically resizing columns is not possible. We used to do it, but it makes GTK+ become very slow with a large playlist (as in, the CPU pegged at 100% for around 30 seconds).

2) Only calling gtk_tree_view_column_set_resizable() is not enough, because the column sizes are not synchronized between playlists and are lost when Audacious is closed and restarted.

I am attaching a patch that fully implements resizeable columns, but it cannot be applied right now because of some bugs in GTK+ that it exposes.

#6 Updated by John Lindgren almost 7 years ago

The columns are now marked "resizable" to GTK+ [1]. I am attaching an updated patch for gtkui that will save and restore column widths once the necessary patches [2] are applied to GTK+.

[1] https://github.com/audacious-media-player/audacious/commit/5dadaafc29f01b2837d01ecc522281b22e5cfc04
[2] https://mail.gnome.org/archives/gtk-devel-list/2013-January/msg00032.html

#7 Updated by John Lindgren almost 7 years ago

  • Status changed from New to Closed
  • Target version set to 3.4
  • % Done changed from 0 to 100

Above-mentioned patch is now committed. GTK+ 3.8+ is required for this to work correctly.
https://github.com/audacious-media-player/audacious-plugins/commit/71f39cd4b2b0976c6812ccf538472fa125f28ca8

Also available in: Atom PDF