Project

General

Profile

Feature #233

Configuration GUI for modplug

Added by Matthew Stapleton over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/modplug
Target version:
Start date:
December 30, 2012
Due date:
% Done:

100%

Estimated time:
Affects version:

Description

Since around 7 September 2011 the modplug plugin has been missing the gui code to configure the preferences.

modplug_preferences.patch.gz (3.97 KB) modplug_preferences.patch.gz Vladimir Strakh, April 19, 2013 01:24

History

#1 Updated by Michael Schwendt over 8 years ago

Very likely it's just waiting for a volunteer to contribute patches that add it back, porting it GTK+ 3 or even Audacious Preferences UI API.

#2 Updated by John Lindgren over 8 years ago

  • Tracker changed from Bug to Feature
  • Subject changed from modplug plugin missing preferences interface to Configuration GUI for modplug
  • Affects version deleted (3.2.4, 3.3.2, 3.3.3)

#3 Updated by Vladimir Strakh about 8 years ago

Hi all.

I've been missing modplug preferences too. Googling around brought me here, and I found out that preferences is not a priority.
So, here's my small contribution - patch that adds preferences page to modplug plugin.
It's implemented in terms of Audacious Preferences UI API, and I tried to keep its look as close as possible to old page.

Any chances that it will be accepted?

#4 Updated by John Lindgren about 8 years ago

  • Status changed from New to Closed
  • Target version set to 3.4
  • % Done changed from 0 to 100
  • Affects version 3.3.4 added

Hi Vladimir, I've committed an adapted version of your patch:
https://github.com/audacious-media-player/audacious-plugins/commit/55b332ef8c97852fd6fa3b4b4a5cf0cdc0638ee6

Thank you for the contribution; I'm sure it will make a lot of modplug users happy.

#5 Updated by John Lindgren about 8 years ago

Just to double-check: are you okay with this code entering the public domain (since that's how the rest of the plugin is licensed)?

#6 Updated by Vladimir Strakh about 8 years ago

Going public domain is absolutely ok :)
thx.

Also available in: Atom PDF