Project

General

Profile

Bug #249

Allow console plugin code to properly determine endianness on *BSD OSes

Added by Brad Smith almost 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/console
Target version:
3.4
Start date:
February 06, 2013
Due date:
% Done:

100%

Estimated time:
Affects version:
3.3.3

Description

The attached patch for the console plugins code will allow it to properly determine the archs endianness on *BSD OS's.

audacious-plugins_endian.diff (708 Bytes) audacious-plugins_endian.diff Brad Smith, February 06, 2013 20:27

History

#1 Updated by John Lindgren almost 12 years ago

  • Subject changed from Allow console plugin code to properly determine endianness on *BSD OS's to Allow console plugin code to properly determine endianness on *BSD OS's

It should be using the WORDS_BIGENDIAN #define from config.h. But that also #defines HAVE_ZLIB_H, which currently causes the plugin to fail to compile. It's a mess. :(

#2 Updated by John Lindgren almost 12 years ago

  • Subject changed from Allow console plugin code to properly determine endianness on *BSD OS's to Allow console plugin code to properly determine endianness on *BSD OS's

I'm not sure what happened to the bug title there ...

#3 Updated by John Lindgren almost 12 years ago

  • Subject changed from Allow console plugin code to properly determine endianness on *BSD OS's to Allow console plugin code to properly determine endianness on *BSD OS's

The plugin is using GLib's byte-order macros now; I presume those work on *BSD.

https://github.com/audacious-media-player/audacious-plugins/commit/f18c908041d59950cccc1fd58fa49072dc56ba75

#4 Updated by John Lindgren almost 12 years ago

  • Subject changed from Allow console plugin code to properly determine endianness on *BSD OS's to Allow console plugin code to properly determine endianness on *BSD OSes
  • Status changed from New to Closed
  • % Done changed from 0 to 100

#5 Updated by Brad Smith almost 12 years ago

AFAIK switching to Glib for the endianness swapping should be good but I'll see for sure when the next alpha goes out.

Also available in: Atom PDF