Project

General

Profile

Bug #288

Time label can increase past length of song when dragging time slider

Added by mimitron - over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/gtkui
Target version:
3.4
Start date:
May 08, 2013
Due date:
% Done:

100%

Estimated time:
Affects version:

Description

Function "Seek forward 5 seconds" and "Seek backward 5 seconds" not work correctly with .wav files.
With .mp3 - OK (xubuntu 13.04).

Many thanks.

03.png (116 KB) 03.png mimitron -, May 11, 2013 18:17
record.wav (339 KB) record.wav mimitron -, May 11, 2013 18:17

History

#1 Updated by John Lindgren over 11 years ago

Works fine here.

#2 Updated by mimitron - over 11 years ago

John Lindgren wrote:

Works fine here.

I have a problem on two different computers, both worth xubuntu 13.04.

#3 Updated by Michael Schwendt over 11 years ago

Works fine here (Fedora 19 development, Audacious 3.4-beta1).

Can you give more details, please? What exactly happens?

#4 Updated by mimitron - over 11 years ago

Can you give more details, please? What exactly happens?

moving the slider bar disproportionate length of the track

#5 Updated by Michael Schwendt over 11 years ago

Two observations:

1) If one drags the playpos slider beyond its right border, the displayed time is not capped at the max.time (= duration). Depending on screen size, the value gets much larger. Also reproducible with other files types, e.g. MP3.

2) If one releases the dragged slider anywhere, playback resumes at a position that doesn't seem to match the displayed time. The time even advances beyond the displayed duration value (not just for the attached file, also for a pretty common "RIFF (little-endian) data, WAVE audio, Microsoft PCM, 16 bit, stereo 44100 Hz" converted from MP3 with SoundConverter). IOW, playback stops sometime later.

#6 Updated by mimitron - over 11 years ago

Michael Schwendt, thank you, that's exactly what I meant when I made ​​this task (unfortunately, I am not fluent in English to describe everything in such detail).

#7 Updated by John Lindgren over 11 years ago

Michael, you seem to be talking about a different bug. The original report was about seeking back or forward 5 seconds (I assume with the arrow keys).

#8 Updated by Michael Schwendt over 11 years ago

Well, that may be true, but seeking with arrow keys (as well as with audtool playback-seek-relative) in WAV files works for me just fine (and I've seen your commit to CLAMP in do_seek(), too). So, the only issues I could fine are with the gtk slider.

#9 Updated by John Lindgren over 11 years ago

I've added another CLAMP to fix the displayed-values-out-of-range problem:
https://github.com/audacious-media-player/audacious-plugins/commit/264d8ead4935c4ae5c8fc1513dc7de7297431cb2

Mimitron, please clarify whether you were reporting the same problem as Michael or if you had another problem with seeking.

#10 Updated by mimitron - over 11 years ago

Mimitron, please clarify whether you were reporting the same problem as Michael or if you had another problem with seeking.

I meant exactly the problems that Michael has written.

#11 Updated by John Lindgren over 11 years ago

  • Subject changed from Function "Seek forward 5 seconds" and "Seek backward 5 seconds" not work correctly with .wav files to Time label can increase past length of song when dragging time slider
  • Category set to plugins/gtkui
  • Status changed from New to Closed
  • Target version set to 3.4
  • % Done changed from 0 to 100

Fixed then.

Also available in: Atom PDF