Project

General

Profile

Bug #291

Integer overflow in mpg123 plugin

Added by Dmitry Petrov over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Major
Assignee:
-
Category:
plugins/mpg123
Target version:
3.4
Start date:
May 14, 2013
Due date:
% Done:

100%

Estimated time:
Affects version:
3.2.2, 3.2.3, 3.3-alpha1, 3.2.4, 3.3-beta1, 3.3-beta2, 3.3, 3.3.1, 3.3.2, 3.3.3, 3.3.4

Description

When playing cue tracks from mp3 file, there is integer overflow in calculating frames_total. As a result track length is calculated incorrectly and this sometimes leads to skipping track entirely (when frames_total is negative).
Attached small patch for audacious-plugins-3.3.4 solves this issue.

audacious-plugins-3.3.4-mpg123-frames-overflow-fix.diff (399 Bytes) audacious-plugins-3.3.4-mpg123-frames-overflow-fix.diff Dmitry Petrov, May 14, 2013 13:19

History

#1 Updated by John Lindgren over 11 years ago

  • Category set to plugins/mpg123
  • Status changed from New to Closed
  • Target version set to 3.4
  • % Done changed from 0 to 100

Also available in: Atom PDF