Project

General

Profile

Bug #418

jump-to-track: Remember filter value not working

Added by Thomas Lange over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
libaudgui
Target version:
Start date:
March 16, 2014
Due date:
% Done:

100%

Estimated time:
Affects version:

Description

The filter is not saved at all,
closing the dialog resets the entry.

I have tested Audacious 3.2.4 with GTK2
and this version is fine.

It seems like the behavior changed with GTK3.

History

#1 Updated by John Lindgren over 5 years ago

This commit is at fault:
https://github.com/audacious-media-player/audacious/commit/c3776fe2c7d55595ffa7dd21c4a98fb5b80a2e1c

The window used to be hidden instead of destroyed when it was closed, so the text entry was not cleared. To fix this, we would have to explicitly save and restore the text entry now. Is it a useful feature? In most cases, I would expect typing a couple of keywords to be faster than editing a previous search. So I'm inclined to just remove the check box.

#2 Updated by Thomas Lange over 5 years ago

I'm fine with removing it.

Also available in: Atom PDF