Project

General

Profile

Bug #66

UI segfault on spc chiptunes with certain tags

Added by Will F. almost 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Major
Assignee:
-
Category:
plugins/console
Target version:
3.2.1
Start date:
January 31, 2012
Due date:
% Done:

100%

Estimated time:
Affects version:
3.2

Description

There is a segfault with spc chiptunes when the tags have something specific, I'm not sure what. I have attached an example.

Eternal_Filena.spc (64.5 KB) Eternal_Filena.spc Will F., January 31, 2012 22:42

History

#2 Updated by John Lindgren almost 13 years ago

  • Category set to plugins/console
  • Status changed from New to Closed
  • % Done changed from 0 to 100
  • Target version set to 3.2.1
  • Affects version added
  • Affects version deleted ()

This was caused by invalid UTF-8 in the tag, which the console plugin should have sanitized. I've fixed this in the console plugin and also added a check in Audacious core to prevent similarly misbehaving plugins from crashing the program in future:

https://github.com/audacious-media-player/audacious/commit/c36b8fb5c89787f4b26bf68ef7c13e798e464867
https://github.com/audacious-media-player/audacious-plugins/commit/c7578194c6c840311ea5254b7101dbe5bf383f8f

Also available in: Atom PDF