Project

General

Profile

Feature #739

WAVEOUT plugin may use Windows events instead of pthread

Added by Carlo Bramini almost 2 years ago. Updated almost 2 years ago.

Status:
Rejected
Priority:
Minor
Assignee:
-
Category:
-
Target version:
-
Start date:
August 12, 2017
Due date:
% Done:

0%

Estimated time:
Affects version:

Description

Hello,
By looking the source of this plugin, perhaps instead of declaring two mutex and a cond pthread objects, it would be better to use two CRITICAL_SECTION and an HANDLE returned by CreateEvent().

I think that it would be better to declare also blocks_free with volatile keyword, it should made safer the WaveOut::period_wait ().

Sincerely.

History

#1 Updated by John Lindgren almost 2 years ago

"Better" why? Are you having problems with the current code?

#2 Updated by Carlo Bramini almost 2 years ago

John Lindgren wrote:

"Better" why? Are you having problems with the current code?

No, I have no problems with current code, I was just thinking that the same thing could be made with genuine WIN32 functions, since this plugin will run only on Windows and nothing else. That's why I was thinking on it as an improvement.

#3 Updated by John Lindgren almost 2 years ago

  • Status changed from New to Rejected

In that case, I prefer the code the way it is.

Also available in: Atom PDF