Project

General

Profile

Bug #808

gnomeshortcuts fix for bug 765 does not work

Added by Michael Schwendt over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/gnome shortcuts
Target version:
3.10
Start date:
July 14, 2018
Due date:
% Done:

100%

Estimated time:
Affects version:
3.9, 3.10

Description

In reply to:

https://github.com/audacious-media-player/audacious-plugins/commit/2002c9b2f4fa7348ab66e4dff889da25f646c813#diff-b54d10e5a554e1f834b63a9f19d5cd43

A few months ago I've pointed out that the commit does not work with GNOME 3.26.2 (Fedora 27). It also doesn't work with GNOME 3.28.1 (Fedora 28).

As a workaround for Audacious 3.9 and GNOME >= 3.26 I went with a single-line fix as incorporated into the following patch. The top part of that patch is for something else, avoiding dbus activation of the g-s-d daemons on non-GNOME systems:
https://src.fedoraproject.org/rpms/audacious-plugins/blob/master/f/audacious-plugins-3.9-gnomeshortcuts.patch

So, by default, Audacious 3.10-beta1 gnomeshortcuts plugin does not work yet:

  • (audacious:26570): WARNING **: 01:34:59.140: Could not grab media player keys: The name org.gnome.SettingsDaemon was not provided by any .service files
    WARNING plugin-init.cc:102 [start_plugin]: GNOME Shortcuts failed to start.

History

#1 Updated by John Lindgren over 6 years ago

I'm guessing this breaks compatibility with GNOME < 3.26; is that true? If so, that's okay with me, but we can strip out some of the fallback code in that case.

I don't use any recent version of GNOME (and have zero interest in doing so) which is why I haven't followed up on this until now. But I would be happy to merge a patch or pull request.

#2 Updated by John Lindgren over 6 years ago

  • % Done changed from 0 to 100
  • Status changed from New to Closed
  • Category set to plugins/gnome shortcuts

Also available in: Atom PDF