Project

General

Profile

Bug #819

Playlist search in Qt5 is really slow on huge playlists

Added by Enne Eziarc over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/qtui
Target version:
3.10.1
Start date:
August 12, 2018
Due date:
% Done:

100%

Estimated time:
Affects version:
3.10

Description

I've got a playlist with just under 150 thousand entries. In Qt5, each keystroke in the Ctrl+F box freezes the UI for several seconds until the results are whittled down to about 10k or less.

In GTK2 the search is instant, which I can understand for the plain UI (it only does a one-at-a-time search, not the same thing) but it's just as fast in the winamp UI too.

History

#1 Updated by John Lindgren over 6 years ago

It certainly doesn't seem like it should be that slow, even to filter the entire playlist. When I have some time, I'll run it under Valgrind and try to find out where the bottleneck is.

#2 Updated by John Lindgren over 6 years ago

  • % Done changed from 0 to 100
  • Target version set to 3.10.1
  • Status changed from New to Closed
  • Category set to plugins/qtui

This change makes a huge improvement (nearly 10x) for me with a playlist of 50,000 entries:
https://github.com/audacious-media-player/audacious-plugins/commit/9d162207ef01c5972e4bb718d390c494f0ad0241

I think that's about as good as it's going to get, so I'll go ahead and close this. If it still seems slow to you, and you have a suggestion for improving it further, I'd be interested.

Also available in: Atom PDF