Project

General

Profile

Feature #909

remember open/close status of equalizer and equalizer-presets windows

Added by Tristan C. 9 months ago. Updated 3 months ago.

Status:
New
Priority:
Minor
Assignee:
-
Category:
libaudgui
Start date:
October 27, 2019
Due date:
% Done:

0%

Estimated time:
Affects version:

Description

For usability purposes, it would be nice if the equalizer and equalizer presets windows would open at startup if they were open at last closure, as it's done for the playlist manager window.

audqt.cc.diff (909 Bytes) audqt.cc.diff Qt Jim Turner, April 22, 2020 01:12
equalizer-qt.cc.diff (1.36 KB) equalizer-qt.cc.diff Qt Jim Turner, April 22, 2020 01:12
equalizer.cc.diff (880 Bytes) equalizer.cc.diff GTK Jim Turner, April 22, 2020 01:13
init.cc.diff (1.13 KB) init.cc.diff GTK Jim Turner, April 22, 2020 01:13

History

#1 Updated by Jim Turner 8 months ago

It's always worked for me in the "skins" interfaces, but I concur, the equalizer window, if open when Audacious closes, should also pop up opened in the same place in the non-skinned interfaces too!

#2 Updated by Jim Turner 3 months ago

Ok, due to lack of response, I've FIXED this for the equalizer window in my forked version. Personally, I don't think the preset window should remain up as it is just one of many secondary popup dialogs. On the Qt side, the equalizer also remembers where it was last popped up (pbly. dependent on whether your window-manager honors "pposition"). Anyway, I've attached the patches against Audacious GIT as/of 4/21.
NOTE!: (BEFORE and UNRELATED to this patch: the aformentioned 4/21 GIT either segfaults or string-leaks frequently when exiting the Qt version)!

Regards,

Jim

#3 Updated by John Lindgren 3 months ago

Jim Turner wrote:

NOTE!: (BEFORE and UNRELATED to this patch: the aformentioned 4/21 GIT either segfaults or string-leaks frequently when exiting the Qt version)!

Please file a separate bug report for this with complete details (Qt version, steps to reproduce, backtrace).

#4 Updated by Jim Turner 3 months ago

Ok, I'll back out the patch, and apply the commit you did today since this, run it again. save the requested debug info, and file a separate bug (assuming it still fails). Either way, please review the patch in the meantime (as I said though, I did a fresh install from Git and ran Audacious BEFORE applying anything!)

Jim

#5 Updated by John Lindgren 3 months ago

I'm personally not working on any new feature development past 4.0. So I will leave it up to one of the other developers to review and/or apply these patches.

#6 Updated by Jim Turner 3 months ago

@John - I saw recently that you're "semi-retiring" from Audacious as it pretty much does what you want (excellent). I've been thinking the exact same thing about my fork of the project, but also, sad to say, due to lack of uptake on my fork (I suck at marketing, lol), but you (all) keep throwing in some interesting things (and some curveballs and fixes) here and there that I just have to play/muck with! ;)

I did test Audacious some more tonite and reported my findings in a new bug (#975), but when I post, I'm not necessarily addressing requests to you personally, but to the Audacious team (to whomever it may concern / is working on that area).

Thanks,

Jim

Also available in: Atom PDF