Project

General

Profile

Bug #587

since 3.7, double size has become extremely large

Added by il lumilore about 9 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Minor
Assignee:
-
Category:
plugins/skins
Target version:
3.7.1
Start date:
November 12, 2015
Due date:
% Done:

100%

Estimated time:
Affects version:
3.7

Description

since 3.7, when clicking double size in winamp skin, the size of the player becomes more than double size and takes up about 1/6th of the screen. Is it possible to make an option where the user selects what the size is? Triple the original size might be too large.

History

#1 Updated by Thomas Lange about 9 years ago

I cannot reproduce this. For me the main window size becomes 550x232 from the original 275x116. Which window manager do you use?

#2 Updated by il lumilore about 9 years ago

kde 5.4 on opensuse

#3 Updated by John Lindgren about 9 years ago

  • Category set to plugins/skins

It's intended to adjust based on the screen resolution. But maybe this will be undesired for most people. I'm open to backing out the change.

#4 Updated by il lumilore about 9 years ago

Maybe a preference toggle to select whether it goes to double or triple original size if double isn't big enough for some people?

#5 Updated by John Lindgren about 9 years ago

  • Status changed from New to Closed
  • Target version set to 3.7.1
  • % Done changed from 0 to 100

I've changed the logic to the following (as explained by the comment in the code):

// The current scaling implementation allows any integer scale factor, but
// the legacy "double size" config option is limited to two choices. For
// now, the two options are floor(DPI/96) and floor(DPI/96)+1. On screens
// up to 191 DPI, this gives the traditional 1x and 2x scale factors.

Then for higher resolution screens you would have:
192-287 DPI: 2x or 3x
288-383 DPI: 3x or 4x
... and so on.

(And obviously still 1x or 2x for screens under 96 DPI, if those exist).

In the long run, we could add a dial that allows any scale factor to be selected, but I think this is sufficient for now. At any rate, it will fix your specific problem of "double size" being triple size instead, which probably no one wants.

Also available in: Atom PDF