Project

General

Profile

Forums » Audacious »

QT and GTK versions of skins ui.

Added by Carlo Bramini over 7 years ago

Hello,
by doing a comparison with WinMerge between the sources of skins ui for QT and GTK, they look very similar, at least at the time of writing.
I'm wondering if you are planning, or if you could evaluate to make something like a "libskin-ui" to be used for both plugins, that it could simplify greatly the code and, why not, to be open for future porting on other toolkits by just implementing few classes.
It would be nice also for the gtkui and qtui interfaces, but unfortunately the sources looks completely different.

Sincerely.


Replies (2)

RE: QT and GTK versions of skins ui. - Added by John Lindgren over 7 years ago

It's a good thought. I thought about doing something like what you describe, and I did try to keep the code common wherever possible, but I stopped short of creating an actual abstraction layer. It seemed like it would be a lot of work.

The Qt UI is completely different from gtkui because we wanted to start from scratch in C++. gtkui was written all in C originally so it doesn't really take advantage of any OO features.

RE: QT and GTK versions of skins ui. - Added by Carlo Bramini over 7 years ago

I hope that this feature request could be put in a TODO list. Not necessary to be implemented tomorrow, but useful for the future.
Sincerely.

    (1-2/2)